From: Jeff Garzik <jgarzik@pobox.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] sky2: phy power problems on 88e805X chips
Date: Thu, 10 Aug 2006 08:32:43 -0400 [thread overview]
Message-ID: <44DB276B.9010505@pobox.com> (raw)
In-Reply-To: <20060809141450.2e104dfe@localhost.localdomain>
Stephen Hemminger wrote:
> On the 88E805X chipsets (used in laptops), the PHY was not getting powered
> out of shutdown properly. The variable reg1 was getting reused incorrectly.
> This is probably the cause of the bug.
> http://bugzilla.kernel.org/show_bug.cgi?id=6471
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
>
> --- netdev-2.6.orig/drivers/net/sky2.c 2006-08-09 14:13:36.000000000 -0700
> +++ netdev-2.6/drivers/net/sky2.c 2006-08-09 14:14:07.000000000 -0700
> @@ -233,6 +233,8 @@
> if (hw->ports > 1)
> reg1 |= PCI_Y2_PHY2_COMA;
> }
> + sky2_pci_write32(hw, PCI_DEV_REG1, reg1);
> + udelay(100);
>
> if (hw->chip_id == CHIP_ID_YUKON_EC_U) {
applied to #upstream-fixes, though I note that the obvious PCI posting
bug remains.
You cannot be assured that the udelay(100) is truly effective without a
flushing readl().
Jeff
prev parent reply other threads:[~2006-08-10 12:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-09 21:14 [PATCH] sky2: phy power problems on 88e805X chips Stephen Hemminger
2006-08-10 12:32 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44DB276B.9010505@pobox.com \
--to=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).