* [DECNET] Fix to multiple tables routing
@ 2006-08-11 14:27 Steven Whitehouse
2006-08-11 15:22 ` Patrick McHardy
2006-08-11 23:43 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Steven Whitehouse @ 2006-08-11 14:27 UTC (permalink / raw)
To: David Miller; +Cc: Patrick Caulfield, Patrick McHardy, netdev
Here is a fix to Patrick McHardy's increase number of routing tables patch
for DECnet. I did just test this and it appears to be working fine with
this patch.
Cc: Patrick McHardy <kaber@trash.net>
Cc: Patrick Caulfield <patrick@tykepenguin.com>
Signed-off-by: Steven Whitehouse <steve@chygwyn.com>
diff --git a/net/decnet/dn_rules.c b/net/decnet/dn_rules.c
index 878312f..c8d9411 100644
--- a/net/decnet/dn_rules.c
+++ b/net/decnet/dn_rules.c
@@ -116,6 +116,7 @@ static struct nla_policy dn_fib_rule_pol
[FRA_SRC] = { .type = NLA_U16 },
[FRA_DST] = { .type = NLA_U16 },
[FRA_FWMARK] = { .type = NLA_U32 },
+ [FRA_TABLE] = { .type = NLA_U32 },
};
static int dn_fib_rule_match(struct fib_rule *rule, struct flowi *fl, int flags)
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [DECNET] Fix to multiple tables routing
2006-08-11 14:27 [DECNET] Fix to multiple tables routing Steven Whitehouse
@ 2006-08-11 15:22 ` Patrick McHardy
2006-08-11 15:30 ` Steven Whitehouse
2006-08-11 23:43 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Patrick McHardy @ 2006-08-11 15:22 UTC (permalink / raw)
To: Steven Whitehouse; +Cc: David Miller, Patrick Caulfield, netdev
Steven Whitehouse wrote:
> Here is a fix to Patrick McHardy's increase number of routing tables patch
> for DECnet. I did just test this and it appears to be working fine with
> this patch.
>
> Cc: Patrick McHardy <kaber@trash.net>
> Cc: Patrick Caulfield <patrick@tykepenguin.com>
> Signed-off-by: Steven Whitehouse <steve@chygwyn.com>
>
> diff --git a/net/decnet/dn_rules.c b/net/decnet/dn_rules.c
> index 878312f..c8d9411 100644
> --- a/net/decnet/dn_rules.c
> +++ b/net/decnet/dn_rules.c
> @@ -116,6 +116,7 @@ static struct nla_policy dn_fib_rule_pol
> [FRA_SRC] = { .type = NLA_U16 },
> [FRA_DST] = { .type = NLA_U16 },
> [FRA_FWMARK] = { .type = NLA_U32 },
> + [FRA_TABLE] = { .type = NLA_U32 },
> };
Looks good. BTW, I noticed something in the DecNET fib_rule conversion
that looks like a bug:
The policy includes this for FRA_SRC/FRA_DST:
[FRA_SRC] = { .type = NLA_U16 },
[FRA_DST] = { .type = NLA_U16 },
But in dn_fib_rule_compare it is used like this:
if (tb[FRA_SRC] && (r->src != nla_get_u32(tb[FRA_SRC])))
return 0;
if (tb[FRA_DST] && (r->dst != nla_get_u32(tb[FRA_DST])))
return 0;
I think this might create problems depending on the endianness.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [DECNET] Fix to multiple tables routing
2006-08-11 15:22 ` Patrick McHardy
@ 2006-08-11 15:30 ` Steven Whitehouse
0 siblings, 0 replies; 4+ messages in thread
From: Steven Whitehouse @ 2006-08-11 15:30 UTC (permalink / raw)
To: Patrick McHardy; +Cc: David Miller, Patrick Caulfield, netdev
Hi,
On Fri, Aug 11, 2006 at 05:22:17PM +0200, Patrick McHardy wrote:
> Steven Whitehouse wrote:
> > Here is a fix to Patrick McHardy's increase number of routing tables patch
> > for DECnet. I did just test this and it appears to be working fine with
> > this patch.
> >
> > Cc: Patrick McHardy <kaber@trash.net>
> > Cc: Patrick Caulfield <patrick@tykepenguin.com>
> > Signed-off-by: Steven Whitehouse <steve@chygwyn.com>
> >
> > diff --git a/net/decnet/dn_rules.c b/net/decnet/dn_rules.c
> > index 878312f..c8d9411 100644
> > --- a/net/decnet/dn_rules.c
> > +++ b/net/decnet/dn_rules.c
> > @@ -116,6 +116,7 @@ static struct nla_policy dn_fib_rule_pol
> > [FRA_SRC] = { .type = NLA_U16 },
> > [FRA_DST] = { .type = NLA_U16 },
> > [FRA_FWMARK] = { .type = NLA_U32 },
> > + [FRA_TABLE] = { .type = NLA_U32 },
> > };
>
> Looks good. BTW, I noticed something in the DecNET fib_rule conversion
> that looks like a bug:
>
> The policy includes this for FRA_SRC/FRA_DST:
>
> [FRA_SRC] = { .type = NLA_U16 },
> [FRA_DST] = { .type = NLA_U16 },
>
> But in dn_fib_rule_compare it is used like this:
>
> if (tb[FRA_SRC] && (r->src != nla_get_u32(tb[FRA_SRC])))
> return 0;
>
> if (tb[FRA_DST] && (r->dst != nla_get_u32(tb[FRA_DST])))
> return 0;
>
> I think this might create problems depending on the endianness.
Yes, good spotting :-) I'll send a patch shortly,
Steve.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [DECNET] Fix to multiple tables routing
2006-08-11 14:27 [DECNET] Fix to multiple tables routing Steven Whitehouse
2006-08-11 15:22 ` Patrick McHardy
@ 2006-08-11 23:43 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2006-08-11 23:43 UTC (permalink / raw)
To: steve; +Cc: patrick, kaber, netdev
From: Steven Whitehouse <steve@chygwyn.com>
Date: Fri, 11 Aug 2006 15:27:42 +0100
> Here is a fix to Patrick McHardy's increase number of routing tables patch
> for DECnet. I did just test this and it appears to be working fine with
> this patch.
>
> Cc: Patrick McHardy <kaber@trash.net>
> Cc: Patrick Caulfield <patrick@tykepenguin.com>
> Signed-off-by: Steven Whitehouse <steve@chygwyn.com>
Applied, thanks Steven.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-08-11 23:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-11 14:27 [DECNET] Fix to multiple tables routing Steven Whitehouse
2006-08-11 15:22 ` Patrick McHardy
2006-08-11 15:30 ` Steven Whitehouse
2006-08-11 23:43 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).