netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Christophe Devriese <Christophe.Devriese@eurid.eu>
Cc: netdev@vger.kernel.org
Subject: Re: Stackable devices.
Date: Sat, 12 Aug 2006 11:43:58 -0700	[thread overview]
Message-ID: <44DE216E.4020609@candelatech.com> (raw)
In-Reply-To: <200608091557.09249.Christophe.Devriese@eurid.eu>

Christophe Devriese wrote:
> It would however be considerable effort to do this. Is this going to end up 
> unapplied like my last patch, or ?

I don't get to make this decision..and when I ask such questions...they
are usually ignored unless I also post a working patch....

I think you could start with just supporting bridging without too
much code.

Ben

> 
> Regards,
> 
> Christophe
> 
> On Tuesday 08 August 2006 18:36, you wrote:
> 
>>Christophe Devriese wrote:
>>
>>>On Wed, Aug 02, 2006 at 10:50:08AM -0700, Ben Greear wrote:
>>>
>>>>Currently, the bridge hook logic is something like:
>>>>
>>>>if (bridge-consumed-pkt) {
>>>>	return
>>>>}
>>>>
>>>>// drop through to other layers
>>>>
>>>>
>>>>There are several other hooks I'd like to see added (pktgen receive
>>>>processing,
>>>>mac-vlans, etc).  Each of these hooks are logically similar to the bridge
>>>>hook,
>>>>ie if it consumes the pkt, return, else, drop through to the next hook
>>>>untill
>>>>we get to the regular protocol processing logic.
>>>>
>>>>I would like to be able to chain layer-2 handlers, such as bridge,
>>>>mac-vlan, pktgen such that if one consumed, you break out of the
>>>>handling, else, you try the next handler.  The handlers can be
>>>>dynamically registered and inserted
>>>>in any order, controllable by user-space and/or module load/unload.
>>>>
>>>>For many of the handlers, the logic will re-insert the packet by
>>>>re-calling the
>>>>netif-rx logic, so there would need to be some protection to keep loops
>>>>from occurring that would recurse too much and overflow the stack.
>>>
>>>I'm also a big fan of a generalized system like this. It would need to
>>>catch both the vlan accelerated path and the normal path.
>>
>>Well, it isn't actually needed for VLANs since VLAN's hook is a protocol
>>handler....
>>
>>Ben
> 
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 



  reply	other threads:[~2006-08-12 19:34 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-28  9:44 PATCH Fix bonding active-backup behavior for VLAN interfaces Christophe Devriese
2006-07-28 16:01 ` Ben Greear
2006-07-28 21:50   ` Christophe Devriese
2006-07-28 21:55     ` Ben Greear
2006-07-28 22:15       ` Christophe Devriese
     [not found]       ` <20060728221455.GA25610@walrus.eth1.org>
     [not found]         ` <44CA8AF1.3020408@candelatech.com>
2006-07-28 22:58           ` Christophe Devriese
2006-07-28 22:55             ` David Miller
2006-07-28 23:14               ` Ben Greear
2006-07-31  3:50       ` David Miller
2006-07-31  8:15         ` Christophe Devriese
2006-07-31 12:30           ` Linville's L2 rant... -- " John W. Linville
2006-07-31 16:48             ` Christophe Devriese
2006-08-01  1:39             ` Jamal Hadi Salim
2006-08-01 12:08               ` John W. Linville
2006-08-01 12:33                 ` Jamal Hadi Salim
2006-08-01 16:10                   ` Ben Greear
2006-08-01 16:52                     ` John W. Linville
2006-08-01 17:04                       ` Ben Greear
2006-08-01 19:47                         ` Krzysztof Halasa
2006-08-01 16:48                   ` John W. Linville
2006-08-01 16:17                 ` Ben Greear
2006-08-01 17:03                   ` John W. Linville
2006-08-01 17:21                     ` Ben Greear
2006-08-02  9:02                       ` Christophe Devriese
2006-08-02 17:37                         ` Stackable devices Stephen Hemminger
2006-08-02 17:50                           ` Ben Greear
2006-08-08 12:03                             ` Christophe Devriese
2006-08-08 16:36                               ` Ben Greear
2006-08-09 13:57                                 ` Christophe Devriese
2006-08-12 18:43                                   ` Ben Greear [this message]
2006-08-12 19:29                                   ` Ben Greear
2006-08-02 20:58           ` PATCH Fix bonding active-backup behavior for VLAN interfaces David Miller
2006-08-03  9:18             ` Krzysztof Oledzki
2006-08-10 18:18               ` Krzysztof Oledzki
2006-08-11  6:45                 ` David Miller
2006-08-11  8:50                   ` Christophe Devriese
2006-08-11  8:53                     ` David Miller
2006-08-14  8:16                   ` Christophe Devriese
2006-08-14  8:47                     ` David Miller
2006-08-14  8:47                     ` David Miller
2006-08-03 13:34             ` Christophe Devriese
2006-08-04  1:01             ` Jay Vosburgh
2006-08-15  0:09               ` David Miller
2006-08-15 22:18                 ` Jay Vosburgh
2006-08-15 22:27                   ` David Miller
2006-08-16 19:30                 ` Krzysztof Oledzki
2006-08-20 19:41                 ` Christophe Devriese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44DE216E.4020609@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=Christophe.Devriese@eurid.eu \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).