From: "Giacomo A. Catenazzi" <cate@debian.org>
To: "Giacomo A. Catenazzi" <cate@debian.org>,
David Miller <davem@davemloft.net>,
7eggert@gmx.de, 7eggert@elstempel.de, shemminger@osdl.org,
mitch.a.williams@intel.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: bonding: cannot remove certain named devices
Date: Wed, 16 Aug 2006 15:59:17 +0200 [thread overview]
Message-ID: <44E324B5.4090005@debian.org> (raw)
In-Reply-To: <20060816133811.GA26471@nostromo.devel.redhat.com>
Bill Nottingham wrote:
> Giacomo A. Catenazzi (cate@debian.org) said:
>>> Are you willing to work to add the special case code necessary to
>>> handle whitespace characters in the device name over all of the kernel
>>> code and also all of the userland tools too?
>> But if you don't handle spaces in userspace, you handle *, ?, [, ], $,
>> ", ', \ in userspace? Should kernel disable also these (insane device
>> chars) chars?
>
> Don't forget unicode characters!
>
> Seriously, while it might be insane to use some of these, I'm wondering
> if trying to filter names is more work than fixing the tools.
Fixing tools in always the good approach, and I think in this case wrong
code is really a security problem. IMHO kernel cannot filter all bad
strings.
So, if for the kernel part it is better to filter spaces, ok!
But we should use this user space problems as the motivation to filter
names.
ciao
cate
next prev parent reply other threads:[~2006-08-16 13:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <6Kd5j-3Y7-3@gated-at.bofh.it>
[not found] ` <6KdRL-5xP-7@gated-at.bofh.it>
[not found] ` <6Ke1p-5N8-7@gated-at.bofh.it>
[not found] ` <6KekO-6u0-25@gated-at.bofh.it>
[not found] ` <6KeXv-7qe-17@gated-at.bofh.it>
[not found] ` <6KfTz-OX-11@gated-at.bofh.it>
[not found] ` <6KfTA-OX-15@gated-at.bofh.it>
2006-08-16 0:02 ` bonding: cannot remove certain named devices Bodo Eggert
2006-08-16 0:10 ` David Miller
2006-08-16 6:35 ` Giacomo A. Catenazzi
2006-08-16 13:38 ` Bill Nottingham
2006-08-16 13:59 ` Giacomo A. Catenazzi [this message]
2006-08-16 15:11 ` Bodo Eggert
2006-08-17 7:29 ` Xavier Bestel
2006-08-17 14:12 ` Bill Nottingham
2006-08-17 23:23 ` David Miller
2006-08-18 0:34 ` Alan Cox
2006-08-18 1:01 ` David Miller
2006-08-18 2:20 ` Bill Nottingham
2006-08-19 3:58 ` Stephen Hemminger
2006-08-18 6:11 ` [PATCH] net: restrict device names from having whitespace Stephen Hemminger
2006-08-18 6:36 ` David Miller
2006-08-18 7:17 ` Xavier Bestel
2006-08-18 9:32 ` Xavier Bestel
2006-08-15 19:48 bonding: cannot remove certain named devices Bill Nottingham
2006-08-15 20:39 ` Mitch Williams
2006-08-15 20:45 ` Bill Nottingham
2006-08-15 21:02 ` Stephen Hemminger
2006-08-15 21:49 ` Bill Nottingham
2006-08-15 22:41 ` Mitch Williams
2006-08-15 22:44 ` Stephen Hemminger
2006-08-15 22:56 ` David Miller
2006-08-15 23:23 ` Stephen Hemminger
2006-08-15 23:26 ` Mitch Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44E324B5.4090005@debian.org \
--to=cate@debian.org \
--cc=7eggert@elstempel.de \
--cc=7eggert@gmx.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).