From: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
To: John Linville <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stefano Brivio <st3-sGOZH3hwPm2sTnJN9+BGXg@public.gmane.org>,
Michael Buesch <mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>,
Bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org
Subject: [PATCH] bcm43xx-softmac: optimization of DMA bitfields.]
Date: Wed, 16 Aug 2006 11:05:16 -0500 [thread overview]
Message-ID: <44E3423C.8050507@lwfinger.net> (raw)
John,
Please pull this patch by MB for the wireless-2.6 tree. It
replaces the one sent earlier today. Somehow, I managed to mangle
it by deleting a semicolon.
Larry
========================================================
This patch depends on the 64bit DMA patch, which is already
submitted for inclusion.
Convert the bitfields in the bcm43xx DMA code to properly
aligned u8 booleans. These flags are accessed in the DMA
hotpath, so it's a good idea to waste a few bytes of memory
for the sake of speed by not requiring masking (and probably
shifting) of the bitfields.
Signed-off-by: Michael Buesch <mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
Signed-Off-By: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
Index: wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_dma.h
===================================================================
--- wireless-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_dma.h 2006-08-16 12:47:27.000000000 +0200
+++ wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_dma.h 2006-08-16 12:49:43.000000000 +0200
@@ -235,9 +235,12 @@
u16 mmio_base;
/* DMA controller index number (0-5). */
int index;
- u8 tx:1, /* TRUE, if this is a TX ring. */
- dma64:1, /* TRUE, if 64-bit DMA is enabled (FALSE if 32bit). */
- suspended:1; /* TRUE, if transfers are suspended on this ring. */
+ /* Boolean. Is this a TX ring? */
+ u8 tx;
+ /* Boolean. 64bit DMA if true, 32bit DMA otherwise. */
+ u8 dma64;
+ /* Boolean. Are transfers suspended on this ring? */
+ u8 suspended;
struct bcm43xx_private *bcm;
#ifdef CONFIG_BCM43XX_DEBUG
/* Maximum number of used slots. */
next reply other threads:[~2006-08-16 16:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-16 16:05 Larry Finger [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-08-16 15:36 [PATCH] bcm43xx-softmac: optimization of DMA bitfields.] Larry Finger
2006-08-16 15:42 ` Johannes Berg
2006-08-16 15:52 ` Larry Finger
[not found] ` <44E33F3E.2000509-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2006-08-16 15:57 ` Michael Buesch
[not found] ` <200608161757.37807.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2006-08-16 16:02 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44E3423C.8050507@lwfinger.net \
--to=larry.finger-tq5ms3gmjblk1umjsbkqmq@public.gmane.org \
--cc=Bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
--cc=mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=st3-sGOZH3hwPm2sTnJN9+BGXg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).