* Re: [RFC][PATCH 0/75] pci_module_init to pci_register_driver conversion
[not found] <20060817042634.0.CrzcY28443.28439.michal@ltg01-fedora.pl>
@ 2006-08-17 5:58 ` Greg KH
2006-08-17 12:35 ` Jeff Garzik
0 siblings, 1 reply; 8+ messages in thread
From: Greg KH @ 2006-08-17 5:58 UTC (permalink / raw)
To: Michal Piotrowski; +Cc: linux-kernel, netdev
On Thu, Aug 17, 2006 at 04:26:35AM +0000, Michal Piotrowski wrote:
>
> Hi,
>
> pci_module_init is obsolete.
>
> This patch series converts pci_module_init to pci_register_driver.
>
>
> Can I remove this?
>
> include/linux/pci.h:385
> /*
> * pci_module_init is obsolete, this stays here till we fix up all usages of it
> * in the tree.
> */
> #define pci_module_init pci_register_driver
As repeated numerous times, it's up to the network developers if they
will take this or not.
I'll hold off on taking this series, please push it through the driver
subsystem maintainers.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC][PATCH 0/75] pci_module_init to pci_register_driver conversion
2006-08-17 5:58 ` [RFC][PATCH 0/75] pci_module_init to pci_register_driver conversion Greg KH
@ 2006-08-17 12:35 ` Jeff Garzik
2006-08-17 12:37 ` Arjan van de Ven
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Jeff Garzik @ 2006-08-17 12:35 UTC (permalink / raw)
To: Greg KH; +Cc: Michal Piotrowski, linux-kernel, netdev
Greg KH wrote:
> On Thu, Aug 17, 2006 at 04:26:35AM +0000, Michal Piotrowski wrote:
>> Hi,
>>
>> pci_module_init is obsolete.
>>
>> This patch series converts pci_module_init to pci_register_driver.
>>
>>
>> Can I remove this?
>>
>> include/linux/pci.h:385
>> /*
>> * pci_module_init is obsolete, this stays here till we fix up all usages of it
>> * in the tree.
>> */
>> #define pci_module_init pci_register_driver
>
> As repeated numerous times, it's up to the network developers if they
> will take this or not.
>
> I'll hold off on taking this series, please push it through the driver
> subsystem maintainers.
It's already in subsystem trees, in fact.
But it is most definitely not 2.6.18-rc material :)
Jeff
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC][PATCH 0/75] pci_module_init to pci_register_driver conversion
2006-08-17 12:35 ` Jeff Garzik
@ 2006-08-17 12:37 ` Arjan van de Ven
2006-08-17 12:43 ` Jeff Garzik
2006-08-17 13:09 ` Michal Piotrowski
2006-08-17 15:52 ` Greg KH
2 siblings, 1 reply; 8+ messages in thread
From: Arjan van de Ven @ 2006-08-17 12:37 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Greg KH, Michal Piotrowski, linux-kernel, netdev
> But it is most definitely not 2.6.18-rc material :)
that part of it isn't.. marking it deprecated so that people doing new
code get a warning probably IS 2.6.18, the sooner that happens the
better....
--
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC][PATCH 0/75] pci_module_init to pci_register_driver conversion
2006-08-17 12:37 ` Arjan van de Ven
@ 2006-08-17 12:43 ` Jeff Garzik
0 siblings, 0 replies; 8+ messages in thread
From: Jeff Garzik @ 2006-08-17 12:43 UTC (permalink / raw)
To: Arjan van de Ven; +Cc: Greg KH, Michal Piotrowski, linux-kernel, netdev
Arjan van de Ven wrote:
>> But it is most definitely not 2.6.18-rc material :)
>
> that part of it isn't.. marking it deprecated so that people doing new
> code get a warning probably IS 2.6.18, the sooner that happens the
> better....
I disagree. With all the cleanups going into 2.6.19, that would just
introduce needless build noise into 2.6.18.
Jeff
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC][PATCH 0/75] pci_module_init to pci_register_driver conversion
2006-08-17 12:35 ` Jeff Garzik
2006-08-17 12:37 ` Arjan van de Ven
@ 2006-08-17 13:09 ` Michal Piotrowski
2006-08-17 13:25 ` Jeff Garzik
2006-08-17 15:52 ` Greg KH
2 siblings, 1 reply; 8+ messages in thread
From: Michal Piotrowski @ 2006-08-17 13:09 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Greg KH, linux-kernel, netdev
On 17/08/06, Jeff Garzik <jeff@garzik.org> wrote:
> Greg KH wrote:
> > On Thu, Aug 17, 2006 at 04:26:35AM +0000, Michal Piotrowski wrote:
> >> Hi,
> >>
> >> pci_module_init is obsolete.
> >>
> >> This patch series converts pci_module_init to pci_register_driver.
> >>
> >>
> >> Can I remove this?
> >>
> >> include/linux/pci.h:385
> >> /*
> >> * pci_module_init is obsolete, this stays here till we fix up all usages of it
> >> * in the tree.
> >> */
> >> #define pci_module_init pci_register_driver
> >
> > As repeated numerous times, it's up to the network developers if they
> > will take this or not.
> >
> > I'll hold off on taking this series, please push it through the driver
> > subsystem maintainers.
>
> It's already in subsystem trees, in fact.
Did you mean http://www.kernel.org/git/?p=linux/kernel/git/davem/net-2.6.19.git;a=shortlog
?
The patches are against 2.6.18-rc4-mm1. Unfortunately patches weren't
delivered to netdev (my fault). I'll add To:<actual maintainer> and
resend.
>
> But it is most definitely not 2.6.18-rc material :)
I agree.
>
> Jeff
>
Regards,
Michal
--
Michal K. K. Piotrowski
LTG - Linux Testers Group
(http://www.stardust.webpages.pl/ltg/wiki/)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC][PATCH 0/75] pci_module_init to pci_register_driver conversion
2006-08-17 13:09 ` Michal Piotrowski
@ 2006-08-17 13:25 ` Jeff Garzik
0 siblings, 0 replies; 8+ messages in thread
From: Jeff Garzik @ 2006-08-17 13:25 UTC (permalink / raw)
To: Michal Piotrowski; +Cc: Greg KH, linux-kernel, netdev
Actually, I stand corrected: netdev-2.6.git#upstream does not contain a
pci_register_driver() patch.
Send the drivers/net piece along to me and I'll apply it.
Jeff
^ permalink raw reply [flat|nested] 8+ messages in thread
* [RFC][PATCH 0/75] pci_module_init to pci_register_driver conversion
@ 2006-08-17 13:26 Michal Piotrowski
0 siblings, 0 replies; 8+ messages in thread
From: Michal Piotrowski @ 2006-08-17 13:26 UTC (permalink / raw)
To: linux-kernel; +Cc: netdev, linux-scsi
Hi,
pci_module_init is obsolete.
This patch series converts pci_module_init to pci_register_driver.
ata/ata_generic.c | 2 +-
ata/pata_pdc2027x.c | 2 +-
char/ipmi/ipmi_si_intf.c | 2 +-
crypto/geode-aes.c | 2 +-
edac/k8_edac.c | 2 +-
net/3c59x.c | 2 +-
net/8139cp.c | 2 +-
net/8139too.c | 2 +-
net/acenic.c | 2 +-
net/amd8111e.c | 2 +-
net/arcnet/com20020-pci.c | 2 +-
net/b44.c | 2 +-
net/bnx2.c | 2 +-
net/cassini.c | 2 +-
net/chelsio/cxgb2.c | 2 +-
net/defxx.c | 2 +-
net/dl2k.c | 2 +-
net/e100.c | 2 +-
net/e1000/e1000_main.c | 2 +-
net/eepro100.c | 2 +-
net/epic100.c | 2 +-
net/fealnx.c | 2 +-
net/forcedeth.c | 2 +-
net/hp100.c | 2 +-
net/ixgb/ixgb_main.c | 2 +-
net/natsemi.c | 2 +-
net/ne2k-pci.c | 2 +-
net/ns83820.c | 2 +-
net/pci-skeleton.c | 2 +-
net/pcnet32.c | 2 +-
net/r8169.c | 2 +-
net/rrunner.c | 2 +-
net/s2io.c | 2 +-
net/saa9730.c | 2 +-
net/sis190.c | 2 +-
net/sis900.c | 2 +-
net/sk98lin/skge.c | 2 +-
net/skfp/skfddi.c | 2 +-
net/skge.c | 2 +-
net/starfire.c | 2 +-
net/sundance.c | 2 +-
net/sungem.c | 2 +-
net/tc35815.c | 2 +-
net/tg3.c | 2 +-
net/tokenring/3c359.c | 2 +-
net/tokenring/lanstreamer.c | 2 +-
net/tokenring/olympic.c | 2 +-
net/tulip/de2104x.c | 2 +-
net/tulip/de4x5.c | 2 +-
net/tulip/dmfe.c | 2 +-
net/tulip/tulip_core.c | 2 +-
net/tulip/winbond-840.c | 2 +-
net/tulip/xircom_tulip_cb.c | 2 +-
net/typhoon.c | 2 +-
net/via-rhine.c | 2 +-
net/via-velocity.c | 2 +-
net/wan/dscc4.c | 2 +-
net/wan/farsync.c | 2 +-
net/wan/lmc/lmc_main.c | 2 +-
net/wan/pc300_drv.c | 2 +-
net/wan/pci200syn.c | 2 +-
net/wan/wanxl.c | 2 +-
net/wireless/atmel_pci.c | 2 +-
net/wireless/ipw2100.c | 2 +-
net/wireless/ipw2200.c | 2 +-
net/wireless/orinoco_nortel.c | 2 +-
net/wireless/orinoco_pci.c | 2 +-
net/wireless/orinoco_plx.c | 2 +-
net/wireless/orinoco_tmd.c | 2 +-
net/wireless/prism54/islpci_hotplug.c | 2 +-
net/yellowfin.c | 2 +-
scsi/ips.c | 2 +-
scsi/megaraid.c | 2 +-
scsi/megaraid/megaraid_sas.c | 2 +-
scsi/tmscsim.c | 2 +-
75 files changed, 75 insertions(+), 75 deletions(-)
Regards,
Michal
--
Michal K. K. Piotrowski
LTG - Linux Testers Group
(http://www.stardust.webpages.pl/ltg/wiki/)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC][PATCH 0/75] pci_module_init to pci_register_driver conversion
2006-08-17 12:35 ` Jeff Garzik
2006-08-17 12:37 ` Arjan van de Ven
2006-08-17 13:09 ` Michal Piotrowski
@ 2006-08-17 15:52 ` Greg KH
2 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2006-08-17 15:52 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Michal Piotrowski, linux-kernel, netdev
On Thu, Aug 17, 2006 at 08:35:12AM -0400, Jeff Garzik wrote:
> Greg KH wrote:
> >On Thu, Aug 17, 2006 at 04:26:35AM +0000, Michal Piotrowski wrote:
> >>Hi,
> >>
> >>pci_module_init is obsolete.
> >>
> >>This patch series converts pci_module_init to pci_register_driver.
> >>
> >>
> >>Can I remove this?
> >>
> >>include/linux/pci.h:385
> >>/*
> >> * pci_module_init is obsolete, this stays here till we fix up all usages
> >> of it
> >> * in the tree.
> >> */
> >>#define pci_module_init pci_register_driver
> >
> >As repeated numerous times, it's up to the network developers if they
> >will take this or not.
> >
> >I'll hold off on taking this series, please push it through the driver
> >subsystem maintainers.
>
> It's already in subsystem trees, in fact.
Great, it can wait until 2.6.19.
> But it is most definitely not 2.6.18-rc material :)
Agreed.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2006-08-17 16:02 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20060817042634.0.CrzcY28443.28439.michal@ltg01-fedora.pl>
2006-08-17 5:58 ` [RFC][PATCH 0/75] pci_module_init to pci_register_driver conversion Greg KH
2006-08-17 12:35 ` Jeff Garzik
2006-08-17 12:37 ` Arjan van de Ven
2006-08-17 12:43 ` Jeff Garzik
2006-08-17 13:09 ` Michal Piotrowski
2006-08-17 13:25 ` Jeff Garzik
2006-08-17 15:52 ` Greg KH
2006-08-17 13:26 Michal Piotrowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).