From: Jeff Garzik <jgarzik@pobox.com>
To: Jesse Huang <jesse@icplus.com.tw>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH 3/6] IP100A Remove CONFIG_SUNDANCE_MMIO, mask of mapping address
Date: Thu, 17 Aug 2006 10:46:58 -0400 [thread overview]
Message-ID: <44E48162.1050104@pobox.com> (raw)
In-Reply-To: <1155841561.4532.13.camel@localhost.localdomain>
Jesse Huang wrote:
> -/* Work-around for Kendin chip bugs. */
> -#ifndef CONFIG_SUNDANCE_MMIO
> -#define USE_IO_OPS 1
> -#endif
Why? This simply eliminates the ability of the user to set the driver
configuration at Kconfig time, requiring them to edit the driver to
achieve the same functionality.
> @@ -491,10 +487,13 @@ #endif
> if (pci_request_regions(pdev, DRV_NAME))
> goto err_out_netdev;
>
> - ioaddr = pci_iomap(pdev, bar, netdev_io_size);
> + ioaddr =(void __iomem *)
> + ((unsigned long)pci_iomap(pdev, bar, netdev_io_size) &
> + 0xffffff80);
NAK, this is very wrong. pci_iomap() returns a "cookie", which you are
not allowed to modify in any way.
Jeff
prev parent reply other threads:[~2006-08-17 14:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-17 19:06 [PATCH 3/6] IP100A Remove CONFIG_SUNDANCE_MMIO, mask of mapping address Jesse Huang
2006-08-17 14:46 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44E48162.1050104@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=jesse@icplus.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).