From: Jeff Garzik <jgarzik@pobox.com>
To: Jesse Huang <jesse@icplus.com.tw>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH 5/6] IP100A correct init and close step
Date: Fri, 18 Aug 2006 07:12:57 -0400 [thread overview]
Message-ID: <44E5A0B9.9090502@pobox.com> (raw)
In-Reply-To: <02ea01c6c28d$20943940$4964a8c0@icplus.com.tw>
Jesse Huang wrote:
> Hi Jeff:
> (1)Should I change to :
> spin_lock_irqsave(&np->lock,flags);
> reset_tx(dev);
> spin_lock_irqrestore(&np->lock,flags);
>
> (2)I will remove date and author information out of source code comment.
Correct.
Also:
(3) Use iowrite16(), not writew(). I just noticed this bug.
iowrite16() will work for both MMIO and IO cycles, writew() only works
for MMIO.
(4) We need a description of why this change is needed. What does
writing 0x500 to DMACtrl actually do? Why do we need to do this?
Jeff
next prev parent reply other threads:[~2006-08-18 11:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-17 19:08 [PATCH 5/6] IP100A correct init and close step Jesse Huang
2006-08-17 14:51 ` Jeff Garzik
2006-08-18 6:11 ` Jesse Huang
2006-08-18 11:12 ` Jeff Garzik [this message]
2006-08-21 3:37 ` Jesse Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44E5A0B9.9090502@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=jesse@icplus.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).