From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Klein Subject: Re: [2.6.19 PATCH 3/7] ehea: queue management Date: Fri, 18 Aug 2006 15:25:11 +0200 Message-ID: <44E5BFB7.4000400@de.ibm.com> References: <200608181331.19501.ossthema@de.ibm.com> <1155903451.4494.168.camel@laptopd505.fenrus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jan-Bernd Themann , netdev , Christoph Raisch , Jan-Bernd Themann , linux-kernel , linux-ppc , Marcus Eder , Thomas Klein Return-path: To: Arjan van de Ven In-Reply-To: <1155903451.4494.168.camel@laptopd505.fenrus.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Arjan van de Ven wrote: >> + queue->queue_length = nr_of_pages * pagesize; >> + queue->queue_pages = vmalloc(nr_of_pages * sizeof(void *)); > > > wow... is this really so large that it warrants a vmalloc()??? Agreed: Replaced with kmalloc() Regards Thomas