From: Auke Kok <auke-jan.h.kok@intel.com>
To: Valerie Henson <val_henson@linux.intel.com>
Cc: netdev@vger.kernel.org
Subject: Re: Proper pci_enable_device() error handling in resume routine
Date: Mon, 21 Aug 2006 11:12:03 -0700 [thread overview]
Message-ID: <44E9F773.1070007@intel.com> (raw)
In-Reply-To: <20060820052922.GH20111@goober>
Valerie Henson wrote:
> I'm trying to properly handle pci_enable_device() errors in the resume
> routines of a couple of tulip drivers. I noticed that several drivers
> pay attention to errors from pci_enable_device() in the init routine
> but ignore it on resume; other drivers vary wildly. What's proper
> behavior when resuming? Extant examples:
>
> 0. Don't call pci_enable_device() at all (8139too)
> 1. Ignore the return value (eepro100, many others)
> 2. Check for failure and bail out, but return success (sungem)
Digging through e1000 I spot that we even pci_enable_device after a PCI error,
so it is good practice I think to make sure the device is up. I suppose that
most people can live without explicit re-enabling the device (most NICs are on
anyway), but if we do enable it explicitly we should certainly check the result
code. Interestingly enough we failed to do this in e1000, so I'll submit a
patch for that later.
Cheers,
Auke
next prev parent reply other threads:[~2006-08-21 18:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-20 5:29 Proper pci_enable_device() error handling in resume routine Valerie Henson
2006-08-21 18:12 ` Auke Kok [this message]
2006-08-21 23:10 ` Valerie Henson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44E9F773.1070007@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=netdev@vger.kernel.org \
--cc=val_henson@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).