Linker error on via-velocity driver

Linker error on via-velocity driver

[Henne]

Hi there!

I found a bug in the via-velocity driver, but I cant find a maintainer for that, so I write to the lists.
This driver depends on CONFIG_INET (tcp/ip) if CONFIG_PM is enabled.
This is tested on i386 and x86_64.
I'm not familiar with network stuff but I don't believe a device should depend on a protocol.
If you are interested to fix it:

make allnoconfig
enable CONFIG_PCI
enable CONFIG_NET
enable CONFIG_NET_ETHERNET
enable CONFIG_NET_PCI
enable CONFIG_VIA_VELOCITY
make

That only happens when CONFIG_PM is enabled. If it's switched off it won't happen.

Greets,
Henne

Re: Linker error on via-velocity driver

[Francois Romieu]

Henne <henne@nachtwindheim.de> :
[...]
> I found a bug in the via-velocity driver, but I cant find a maintainer
> for that, so I write to the lists.
> This driver depends on CONFIG_INET (tcp/ip) if CONFIG_PM is enabled.
> This is tested on i386 and x86_64.
> I'm not familiar with network stuff but I don't believe a device should
> depend on a protocol.

See the comment on top of velocity_get_ip() related to wol and arp.

How does it behave with the patch below:

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 3918990..30f21b6 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2173,6 +2173,7 @@ config VIA_VELOCITY
 	select CRC32
 	select CRC_CCITT
 	select MII
+	select INET if PM
 	help
 	  If you have a VIA "Velocity" based network card say Y here.
 

-- 
Ueimor