From: Jeff Garzik <jgarzik@pobox.com>
To: Jeff@lime.pobox.com, Kirsher <jeffrey.t.kirsher@intel.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
John Ronciak <john.ronciak@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [PATCH] ethtool v4: add autoneg advertise feature
Date: Thu, 24 Aug 2006 02:26:50 -0400 [thread overview]
Message-ID: <44ED46AA.60004@pobox.com> (raw)
In-Reply-To: <20060805054256.14081.74770.stgit@lunar.tarbal.com>
Jeff@lime.pobox.com wrote:
> @@ -598,25 +608,7 @@ static void parse_cmdline(int argc, char
> }
> }
>
> - if (autoneg_wanted == AUTONEG_ENABLE){
> - if (speed_wanted == SPEED_10 && duplex_wanted == DUPLEX_HALF)
> - advertising_wanted = ADVERTISED_10baseT_Half;
> - else if (speed_wanted == SPEED_10 &&
> - duplex_wanted == DUPLEX_FULL)
> - advertising_wanted = ADVERTISED_10baseT_Full;
> - else if (speed_wanted == SPEED_100 &&
> - duplex_wanted == DUPLEX_HALF)
> - advertising_wanted = ADVERTISED_100baseT_Half;
> - else if (speed_wanted == SPEED_100 &&
> - duplex_wanted == DUPLEX_FULL)
> - advertising_wanted = ADVERTISED_100baseT_Full;
> - else if (speed_wanted == SPEED_1000 &&
> - duplex_wanted == DUPLEX_HALF)
> - advertising_wanted = ADVERTISED_1000baseT_Half;
> - else if (speed_wanted == SPEED_1000 &&
> - duplex_wanted == DUPLEX_FULL)
> - advertising_wanted = ADVERTISED_1000baseT_Full;
> - else
> + if ((autoneg_wanted == AUTONEG_ENABLE) && (advertising_wanted < 0)) {
This will change existing behavior of the tool, AFAICS.
Jeff
next parent reply other threads:[~2006-08-24 6:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060805054256.14081.74770.stgit@lunar.tarbal.com>
2006-08-24 6:26 ` Jeff Garzik [this message]
2006-08-24 15:22 ` [PATCH] ethtool v4: add autoneg advertise feature Jeff Kirsher
2006-08-24 15:41 ` Michael Chan
2006-08-24 15:54 ` Jeff Kirsher
2006-08-24 15:59 ` Auke Kok
2006-08-24 16:05 ` Auke Kok
2006-08-24 16:12 ` Jeff Kirsher
2006-08-25 23:42 ` Bill Fink
2006-08-26 0:28 ` Jeff Kirsher
2006-08-26 0:58 ` Bill Fink
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44ED46AA.60004@pobox.com \
--to=jgarzik@pobox.com \
--cc=Jeff@lime.pobox.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).