From: Larry Finger <Larry.Finger@lwfinger.net>
To: Jiri Benc <jbenc@suse.cz>
Cc: John Linville <linville@tuxdriver.com>, netdev@vger.kernel.org
Subject: Re: [PATCH 1/4] Try 2: Add wireless statistics to d80211
Date: Thu, 24 Aug 2006 09:39:52 -0500 [thread overview]
Message-ID: <44EDBA38.4020109@lwfinger.net> (raw)
In-Reply-To: <20060824135934.4df0b1ba@griffin.suse.cz>
Jiri Benc wrote:
> On Wed, 23 Aug 2006 22:02:03 -0500, Larry Finger wrote:
>> This patch modifies d80211 to add wireless statistics.
>> + /* This is maximum value of rssi reported by this interface
>> + */
>> + int maxssi;
>
> Device, not interface. And please do not put */ to a new line.
Noted on the first part, but I would like a clarification regarding style. I put the */ on the
second line to match the rest of that section. Should a patch try to keep the local style in that
part of the code, or change it to a some other standard?
Larry
next prev parent reply other threads:[~2006-08-24 14:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-24 3:02 [PATCH 1/4] Try 2: Add wireless statistics to d80211 Larry Finger
2006-08-24 11:59 ` Jiri Benc
2006-08-24 14:39 ` Larry Finger [this message]
2006-08-24 15:03 ` Jiri Benc
2006-08-24 17:45 ` Simon Barber
2006-08-24 18:17 ` Larry Finger
-- strict thread matches above, loose matches on Subject: below --
2006-08-24 14:28 Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44EDBA38.4020109@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=jbenc@suse.cz \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).