From mboxrd@z Thu Jan 1 00:00:00 1970 From: Auke Kok Subject: Re: [PATCH] ethtool v4: add autoneg advertise feature Date: Thu, 24 Aug 2006 08:59:30 -0700 Message-ID: <44EDCCE2.3030408@intel.com> References: <1551EAE59135BE47B544934E30FC4FC093FAA2@NT-IRVA-0751.brcm.ad.broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jeff Kirsher , Jeff Garzik , Jeff@lime.pobox.com, netdev@vger.kernel.org, David Miller , John Ronciak , Jesse Brandeburg Return-path: Received: from mga01.intel.com ([192.55.52.88]:17476 "EHLO fmsmga101-1.fm.intel.com") by vger.kernel.org with ESMTP id S1030213AbWHXQBR (ORCPT ); Thu, 24 Aug 2006 12:01:17 -0400 To: Michael Chan In-Reply-To: <1551EAE59135BE47B544934E30FC4FC093FAA2@NT-IRVA-0751.brcm.ad.broadcom.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Michael Chan wrote: > Jeff Kirsher wrote: > >> The old way of setting autonegotiation was using the >> following command: >> ethtool -s ethx speed 100 duplex full auto on >> now the command would be >> ethtool -s ethx auto on advertise 0x08 >> both commands would result in only advertising 100 FULL. >> >> There still needs to be a change made to the man file to reflect the >> change in the behavior of ethtool, which I have not done. But this >> patch will allow for greater flexibility in setting autonegotiation >> speeds. > > It is more flexible, but less intuitive. The user now has to > remember hex values instead of the more intuitive speed and > duplex. Perhaps we can keep the old method of using speed and > duplex, while adding the new method of specifying hex values? the patch doesn't remove the old method, it merely adds a second path to the speed/duplex setting. Using the "old" syntax will still work. Cheers, Auke