From: Patrick McHardy <kaber@trash.net>
To: Thomas Graf <tgraf@suug.ch>
Cc: Linux Netdev List <netdev@vger.kernel.org>, jamal <hadi@cyberus.ca>
Subject: Re: [NET_SCHED]: Add mask support to fwmark classifier
Date: Fri, 25 Aug 2006 14:02:38 +0200 [thread overview]
Message-ID: <44EEE6DE.4090703@trash.net> (raw)
In-Reply-To: <20060825105428.GR3470@postel.suug.ch>
Thomas Graf wrote:
> * Patrick McHardy <kaber@trash.net> 2006-08-25 12:29
>
>>The problem is that in order to avoid walking through all filters
>>contained in one instance, we need to mask the value before the
>>lookup. This means all filters share the same mask, which is
>>taken from the first filter created and stored in the filter head.
>>The user interface however always refers to a single filter,
>>not the head, so it can't be changed afterwards unless we just
>>overwrite it whenever a new filter is installed. Both is not
>>really perfect. The current patch doesn't allow to change the
>>mark and enforces that all filters use the same one, which I think
>>is better than allowing inconsistent configurations.
>
>
> The other option gets down to replacing the hash table with a
> list and that's not an option in my opinion. This looks very
> good to me.
Great, thanks. I'll send it off to Dave with two similar patches
for IPv4 and DecNET routing rules.
next prev parent reply other threads:[~2006-08-25 12:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-25 10:29 [NET_SCHED]: Add mask support to fwmark classifier Patrick McHardy
2006-08-25 10:54 ` Thomas Graf
2006-08-25 12:02 ` Patrick McHardy [this message]
2006-08-25 12:52 ` jamal
2006-08-25 14:55 ` jamal
2006-08-26 11:15 ` Patrick McHardy
-- strict thread matches above, loose matches on Subject: below --
2006-08-25 12:14 Patrick McHardy
2006-08-25 23:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44EEE6DE.4090703@trash.net \
--to=kaber@trash.net \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).