netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brice Goglin <brice@myri.com>
To: Jesse Brandeburg <jesse.brandeburg@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: myri10ge conversion to non-contiguous skb
Date: Tue, 29 Aug 2006 00:41:39 -0400	[thread overview]
Message-ID: <44F3C583.2030900@myri.com> (raw)
In-Reply-To: <4807377b0608272336v1d64bc5bh320dee7f08667f79@mail.gmail.com>

Jesse Brandeburg wrote:
> On 8/24/06, Brice Goglin <brice@myri.com> wrote:
>> During the submission of the myri10ge driver, some people raised the
>> question of using pages (or any kind of non-contiguous skb) instead of
>> our current 16kB contiguous skb. We are looking at this right now and it
>> is not clear what solution is the best. From what we understand, Linux
>> provides two mostly redundant mechanisms to handle discontinuous skb,
>> the skb->frags and the skb->frag_list, s2io using the latter while e1000
>> uses the former. Is one or the other recommended? What is the purpose of
>> having them both in the net core?
>
> you really only have one option, to use PAGE_SIZE pages and frags[]
> w/nr_frags.  e1000 tried the frag_list option but that is used by ip
> reassembly and badly conflicts with driver generated frag_list.

Ok, thanks for the clarification, we'll use frags then.

Is s2io going to be converted from frag_list to frags then?

Brice



      reply	other threads:[~2006-08-29  4:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-24 22:26 myri10ge conversion to non-contiguous skb Brice Goglin
2006-08-28  6:36 ` Jesse Brandeburg
2006-08-29  4:41   ` Brice Goglin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44F3C583.2030900@myri.com \
    --to=brice@myri.com \
    --cc=jesse.brandeburg@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).