* [RFC] Patch to add board revision to the WLAN chip_id printout
@ 2006-09-01 15:28 Larry Finger
2006-09-01 19:00 ` Michael Buesch
0 siblings, 1 reply; 2+ messages in thread
From: Larry Finger @ 2006-09-01 15:28 UTC (permalink / raw)
To: Michael Buesch; +Cc: Stefano Brivio, netdev, Broadcom Linux
Michael,
This patch includes the board revision in the chip_id printk for the ssb version of bcm43xx-d80211
and is meant to be applied to wireless-dev. As we have seen, behavior of the chips can be dependent
on the rev level, thus a need to have it in the log.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Index: wireless-dev/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c
===================================================================
--- wireless-dev.orig/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c
+++ wireless-dev/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c
@@ -3346,7 +3346,8 @@ static int bcm43xx_attach_board(struct b
if (err)
goto err_chipset_detach;
- printk(KERN_INFO PFX "Broadcom %04X WLAN found\n", bcm->ssb.chip_id);
+ printk(KERN_INFO PFX "Broadcom %04X WLAN, Revision %d found\n",
+ bcm->ssb.chip_id, bcm->board_revision);
/* Attach all IO cores to the backplane. */
coremask = 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFC] Patch to add board revision to the WLAN chip_id printout
2006-09-01 15:28 [RFC] Patch to add board revision to the WLAN chip_id printout Larry Finger
@ 2006-09-01 19:00 ` Michael Buesch
0 siblings, 0 replies; 2+ messages in thread
From: Michael Buesch @ 2006-09-01 19:00 UTC (permalink / raw)
To: Larry Finger; +Cc: Stefano Brivio, netdev, Broadcom Linux
On Friday 01 September 2006 17:28, Larry Finger wrote:
> Michael,
>
> This patch includes the board revision in the chip_id printk for the ssb version of bcm43xx-d80211
> and is meant to be applied to wireless-dev. As we have seen, behavior of the chips can be dependent
> on the rev level, thus a need to have it in the log.
Any specific example on this?
I mean, every revision in the chip (and bcm43xx has a _lot_) can
(and does) change behaviour. But I still think we shouldn't print them
all on initialization. ;)
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> Index: wireless-dev/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c
> ===================================================================
> --- wireless-dev.orig/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c
> +++ wireless-dev/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c
> @@ -3346,7 +3346,8 @@ static int bcm43xx_attach_board(struct b
> if (err)
> goto err_chipset_detach;
>
> - printk(KERN_INFO PFX "Broadcom %04X WLAN found\n", bcm->ssb.chip_id);
> + printk(KERN_INFO PFX "Broadcom %04X WLAN, Revision %d found\n",
> + bcm->ssb.chip_id, bcm->board_revision);
>
> /* Attach all IO cores to the backplane. */
> coremask = 0;
>
--
Greetings Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-09-01 19:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-01 15:28 [RFC] Patch to add board revision to the WLAN chip_id printout Larry Finger
2006-09-01 19:00 ` Michael Buesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).