* [PATCH] remove dead code from bcm43xx-softmac
@ 2006-09-04 4:38 Larry Finger
[not found] ` <44FBADE0.3010905-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Larry Finger @ 2006-09-04 4:38 UTC (permalink / raw)
To: John Linville
Cc: netdev-u79uwXL29TY76Z2rM5mHXA, Stefano Brivio, Michael Buesch,
Bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w
John,
Please queue the following patch for wireless-2.6. It removes some code that was made obsolete by
the wireless statistics changes of several weeks ago, but was not noticed them.
Thanks,
Larry
=================
This patch removes code that was make obsolete when the wireless statistics in bcm43xx-softmac were
changed, but was overlooked at that time. The value of bcm->stats.link_quality computed here is
never used.
Signed-off-by: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
Index: wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
===================================================================
--- wireless-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_main.c
+++ wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
@@ -1549,17 +1549,7 @@ static void handle_irq_noise(struct bcm4
else
average -= 48;
-/* FIXME: This is wrong, but people want fancy stats. well... */
-bcm->stats.noise = average;
- if (average > -65)
- bcm->stats.link_quality = 0;
- else if (average > -75)
- bcm->stats.link_quality = 1;
- else if (average > -85)
- bcm->stats.link_quality = 2;
- else
- bcm->stats.link_quality = 3;
-// dprintk(KERN_INFO PFX "Link Quality: %u (avg was %d)\n", bcm->stats.link_quality, average);
+ bcm->stats.noise = average;
drop_calculation:
bcm->noisecalc.calculation_running = 0;
return;
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <44FBADE0.3010905-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>]
* Re: [PATCH] remove dead code from bcm43xx-softmac [not found] ` <44FBADE0.3010905-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org> @ 2006-09-04 6:51 ` Michael Buesch 2006-09-04 13:16 ` Larry Finger 0 siblings, 1 reply; 3+ messages in thread From: Michael Buesch @ 2006-09-04 6:51 UTC (permalink / raw) To: Larry Finger Cc: netdev-u79uwXL29TY76Z2rM5mHXA, Stefano Brivio, John Linville, Bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w On Monday 04 September 2006 06:38, Larry Finger wrote: > John, > > Please queue the following patch for wireless-2.6. It removes some code that was made obsolete by > the wireless statistics changes of several weeks ago, but was not noticed them. > > Thanks, > > Larry > > ================= > > This patch removes code that was make obsolete when the wireless statistics in bcm43xx-softmac were > changed, but was overlooked at that time. The value of bcm->stats.link_quality computed here is > never used. So you can also remove the actual variable, no? > Signed-off-by: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org> > > Index: wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c > =================================================================== > --- wireless-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_main.c > +++ wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c > @@ -1549,17 +1549,7 @@ static void handle_irq_noise(struct bcm4 > else > average -= 48; > > -/* FIXME: This is wrong, but people want fancy stats. well... */ > -bcm->stats.noise = average; > - if (average > -65) > - bcm->stats.link_quality = 0; > - else if (average > -75) > - bcm->stats.link_quality = 1; > - else if (average > -85) > - bcm->stats.link_quality = 2; > - else > - bcm->stats.link_quality = 3; > -// dprintk(KERN_INFO PFX "Link Quality: %u (avg was %d)\n", bcm->stats.link_quality, average); > + bcm->stats.noise = average; > drop_calculation: > bcm->noisecalc.calculation_running = 0; > return; > -- Greetings Michael. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] remove dead code from bcm43xx-softmac 2006-09-04 6:51 ` Michael Buesch @ 2006-09-04 13:16 ` Larry Finger 0 siblings, 0 replies; 3+ messages in thread From: Larry Finger @ 2006-09-04 13:16 UTC (permalink / raw) To: Michael Buesch; +Cc: Stefano Brivio, netdev, Bcm43xx-dev, John Linville Michael Buesch wrote: > On Monday 04 September 2006 06:38, Larry Finger wrote: >> John, >> >> Please queue the following patch for wireless-2.6. It removes some code that was made obsolete by >> the wireless statistics changes of several weeks ago, but was not noticed them. >> >> Thanks, >> >> Larry >> >> ================= >> >> This patch removes code that was make obsolete when the wireless statistics in bcm43xx-softmac were >> changed, but was overlooked at that time. The value of bcm->stats.link_quality computed here is >> never used. > > So you can also remove the actual variable, no? Yes. Larry ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-09-04 13:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-04 4:38 [PATCH] remove dead code from bcm43xx-softmac Larry Finger
[not found] ` <44FBADE0.3010905-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2006-09-04 6:51 ` Michael Buesch
2006-09-04 13:16 ` Larry Finger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).