From: Jeff Garzik <jgarzik@pobox.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: netdev@vger.kernel.org, Pierre Ossman <drzeus-list@drzeus.cx>,
akpm@osdl.org
Subject: Re: [PATCH 3/7] 8139cp: ring_info removal for the receive path
Date: Wed, 06 Sep 2006 10:47:00 -0400 [thread overview]
Message-ID: <44FEDF64.4000105@pobox.com> (raw)
In-Reply-To: <20060831204954.GC14181@electric-eye.fr.zoreil.com>
Francois Romieu wrote:
> The ring_info.len field is not used at all. cp_private.rx_skb is
> turned into an array of sk_buff *.
>
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Need to remove the now-dead struct ring_info.
Otherwise, patchset looks OK.
When fixed, I'll pull into #upstream, just let me know...
Jeff
next prev parent reply other threads:[~2006-09-06 14:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-31 20:47 [PATCH 0/7] 8139cp: misc minor changes Francois Romieu
2006-08-31 20:48 ` [PATCH 1/7] 8139cp: trim ring_info Francois Romieu
2006-08-31 20:49 ` [PATCH 2/7] 8139cp: remove gratuitous indirection Francois Romieu
2006-08-31 20:49 ` [PATCH 3/7] 8139cp: ring_info removal for the receive path Francois Romieu
2006-09-06 14:47 ` Jeff Garzik [this message]
2006-09-10 21:10 ` Francois Romieu
2006-08-31 20:51 ` [PATCH 4/7] 8139cp: sync the device private data with its r8169 counterpart Francois Romieu
2006-08-31 20:51 ` [PATCH 5/7] 8139cp: removal of useless BUG_ON() check Francois Romieu
2006-08-31 20:52 ` [PATCH 6/7] 8139cp: pci_get_drvdata(pdev) can not be NULL in suspend handler Francois Romieu
2006-08-31 20:53 ` [PATCH 7/7] 8139cp: use PCI_DEVICE() to shorten the PCI device table Francois Romieu
2006-08-31 21:28 ` [PATCH 0/7] 8139cp: misc minor changes Pierre Ossman
2006-09-01 11:20 ` Francois Romieu
2006-09-01 11:33 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44FEDF64.4000105@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=drzeus-list@drzeus.cx \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).