netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH]: ethtool: typo fix for e1000
@ 2006-09-01 22:42 Auke Kok
  2006-09-06 15:10 ` Jeff Garzik
  0 siblings, 1 reply; 2+ messages in thread
From: Auke Kok @ 2006-09-01 22:42 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: NetDev, Jesse Brandeburg, Auke Kok

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: ethtool_git_typo_fix.patch --]
[-- Type: text/x-patch, Size: 587 bytes --]


e1000: Typo fix.

Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>

diff --git a/e1000.c b/e1000.c
index 6de27ca..6741323 100644
--- a/e1000.c
+++ b/e1000.c
@@ -372,7 +372,7 @@ e1000_dump_regs(struct ethtool_drvinfo *
 		"      Descriptor minimum threshold size: %s\n"
 		"      Broadcast accept mode:             %s\n"
 		"      VLAN filter:                       %s\n"
-		"      Cononical form indicator:          %s\n"
+		"      Canonical form indicator:          %s\n"
 		"      Discard pause frames:              %s\n"
 		"      Pass MAC control frames:           %s\n",
 		reg,

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH]: ethtool: typo fix for e1000
  2006-09-01 22:42 [PATCH]: ethtool: typo fix for e1000 Auke Kok
@ 2006-09-06 15:10 ` Jeff Garzik
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2006-09-06 15:10 UTC (permalink / raw)
  To: Auke Kok; +Cc: NetDev, Jesse Brandeburg

ACK patch, NAK form.

You cannot attach the patch description and signed-off-by line.  It 
makes review much more difficult (many mail readers don't allow easy 
replies to attachments), and git-applymbox does not see the patch 
description.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-09-06 15:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-01 22:42 [PATCH]: ethtool: typo fix for e1000 Auke Kok
2006-09-06 15:10 ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).