From: Jeff Garzik <jgarzik@pobox.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/5] skge: irq lock race
Date: Wed, 06 Sep 2006 11:19:13 -0400 [thread overview]
Message-ID: <44FEE6F1.7010701@pobox.com> (raw)
In-Reply-To: <20060901225449.239532256@zqx3.pdx.osdl.net>
Stephen Hemminger wrote:
> The driver needs to access the IRQ status inside of lock to avoid
> races with other places changing IRQ mask etc. This may be related
> to some of the SMP bugs reported against skge in kernel bugzilla.
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
>
> --- netdev-2.6.orig/drivers/net/skge.c
> +++ netdev-2.6/drivers/net/skge.c
> @@ -2891,13 +2891,15 @@ static irqreturn_t skge_intr(int irq, vo
> {
> struct skge_hw *hw = dev_id;
> u32 status;
> + int handled = 0;
>
> + spin_lock(&hw->hw_lock);
> /* Reading this register masks IRQ */
> status = skge_read32(hw, B0_SP_ISRC);
> if (status == 0)
> - return IRQ_NONE;
> + goto out;
You also need to check for device/hardware fault here (status==0xffffffff).
Jeff
next prev parent reply other threads:[~2006-09-06 15:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-01 22:53 [PATCH 0/5] skge update Stephen Hemminger
2006-09-01 22:53 ` [PATCH 1/5] skge: use netdev_alloc_skb Stephen Hemminger
2006-09-06 15:19 ` Jeff Garzik
2006-09-01 22:53 ` [PATCH 2/5] skge: irq lock race Stephen Hemminger
2006-09-06 15:19 ` Jeff Garzik [this message]
2006-09-06 18:06 ` [PATCH] skge: heck for PCI hotplug during IRQ Stephen Hemminger
2006-09-11 13:07 ` Jeff Garzik
2006-09-01 22:53 ` [PATCH 3/5] skge: use NAPI for transmit complete Stephen Hemminger
2006-09-01 22:53 ` [PATCH 4/5] skge: version 1.8 Stephen Hemminger
2006-09-01 22:53 ` [PATCH 5/5] skge: pci_post bugs Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44FEE6F1.7010701@pobox.com \
--to=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).