From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73C01C43381 for ; Thu, 14 Feb 2019 04:10:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4198421904 for ; Thu, 14 Feb 2019 04:10:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Eq/RTgLn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732770AbfBNEKm (ORCPT ); Wed, 13 Feb 2019 23:10:42 -0500 Received: from mail-ot1-f67.google.com ([209.85.210.67]:45982 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727739AbfBNEKm (ORCPT ); Wed, 13 Feb 2019 23:10:42 -0500 Received: by mail-ot1-f67.google.com with SMTP id 32so8247578ota.12 for ; Wed, 13 Feb 2019 20:10:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=G3P80SceJz+U11l4RFsySolc++Q5J6eAXTvS8kZ1LpI=; b=Eq/RTgLndlSkyOOWcDa2dT4jD7ZANNXfIvEBkivYA0EVqYGtG7UChCFEM9LcIs62b8 mBOGbTIWKdA7986qoz7I66SzUpgHVH6u4LS0sEqjGDnNdLuFyK0XRLbZEAtizpy+LoK8 NT/3oXuQ8gXh0jT+6A79gtt+BTLIebfT9BbYDY9kNIRjambftprj6kMT7QDgV6Ok26yt FADZsW/7RE4CuIsWbW5dNlcFhf6AvoRPX43iGHKw4zS9QJapy8Mkd5xJM7sLpw6qGRis VfXybjQCm1Jkw4tfccQSxXP1AL+puoB79RFa0MT8vZjOywP9dzFzlpojZVqMM0v8FGse 5tng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=G3P80SceJz+U11l4RFsySolc++Q5J6eAXTvS8kZ1LpI=; b=M5o2nRT1T7GAcmHbx4T2qJdcKNQo1i+6c5hNKTuEEOm8a6GTGHOC5jTa04kFK0c1La q7L87fEMxkLBu4zjY4opNSt4qitOToTkZucj4g5zLCSD8A6RJ2ogoHF7BBrcoSze+3XI P52jUbQwnb2wGF+NIsGD7lPhKxXbPfw8Mau0Q0AWa5G+KQN8hj1KG/YioXi4b84HA2cL WGPsmG8u2ogIShQskGlg9CMzOlBM5o6ghmrnG/8BdOwtR0m1UWL3L8CYcgUn0pIZr30e s8nfJiPvgki3glhA98eH7yAFYyo0QQkE1BI/XOknsURzc2UrZRZNq1b/hYNacO+u6H0w dJZw== X-Gm-Message-State: AHQUAubO7rRXX+A5AvzETMVI/jms4rGRrrgNoucfHjZvbF29tu1Qgrc0 Nyj0NuvPe1C7wRPD0sImjoc= X-Google-Smtp-Source: AHgI3IakReGF7Xi3b/STz0Z3eux93drvxPwREqGHOq7rfMO4m/yEtX10hpsQbN27rSc+lCtHCfcfZA== X-Received: by 2002:a05:6830:1292:: with SMTP id z18mr988922otp.161.1550117441156; Wed, 13 Feb 2019 20:10:41 -0800 (PST) Received: from [192.168.1.3] (ip68-228-73-187.oc.oc.cox.net. [68.228.73.187]) by smtp.gmail.com with ESMTPSA id i5sm596841oia.46.2019.02.13.20.10.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Feb 2019 20:10:40 -0800 (PST) Subject: Re: [PATCH net] net: phy: fix interrupt handling in non-started states To: Heiner Kallweit , Andrew Lunn , David Miller Cc: "netdev@vger.kernel.org" , Russell King - ARM Linux References: <25e86edc-0b88-8c03-b692-776e971331f2@gmail.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; keydata= mQENBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAG0KEZsb3JpYW4gRmFpbmVsbGkgPGZhaW5lbGxpQGJyb2FkY29tLmNvbT6JAccEEAECALEF AlPAG9YXCgABv0jL/n0t8VEFmtDa8j7qERo7AN0gFAAAAAAAFgABa2V5LXVzYWdlLW1hc2tA cGdwLmNvbY4wFIAAAAAAIAAHcHJlZmVycmVkLWVtYWlsLWVuY29kaW5nQHBncC5jb21wZ3Bt aW1lCAsJCAcDAgEKAhkBBReAAAAAGRhsZGFwOi8va2V5cy5icm9hZGNvbS5jb20FGwMAAAAD FgIBBR4BAAAABBUICQoACgkQgTG1xCm8ZqD+Dgf9HhhzqvJYIPomNeg+ll7/TbzWb871E+HQ TaufJQFQwLEbgdFSZO2uj4UqfDpCyTwtHTVMJogWt3pCAE1sadeIY8OlT6918ofKIl8AiHj2 BlfL7ASZ5wzkRMt/4TZoinq9O1tPEynb5G6PdZTV3UQtmSGnpt2EOu7KtRJsnThBiXoOO9TJ Asg4vXJ0ZM1y/MPhQlZbPCHQZFe1gaVWBPLGnLyWyeprqgSLWHaGqrUhlfK1sLuJK1bjYDCI NetK0pS4cA4ZJgogr5FrtV64R19zLl02mt/Yj7rAmjC3ZBuwVi3V35kD8Kd4d9QM2apsiILV bzGbtVCSUgvxI+1SsJEm3bkBDQRTwBvBAQgArGvvWip77T4xgJztZp9YRylAcVTC9gtx0Gg6 eYk/EPANGm9TkuGpI++T/Il2H2TjFQNC7eubWohbYj0+6Tmf8nP+VmyobDxPXcMrK7x4xy9o D+Kub2Vf0SXbsM8fL/SqzGbFWZSm73L1L4GZoxvYIz0i7LExYSX2u5YVLaMBaH9HwKt2cvr7 MuTrRHtcbOZImoXT29g2UnoF1uwxYNeRhZY/lRvVkkY0lDipPuDwg3SpfHMtCybPq1uAswQd gEbHzRsEXwCR1OF3pIuGt4I3tSEhH/k1caqi0BlqjbGUOkku44xC2gf1ZU267FBBkdV3yJ/7 KnrJEnkMCYhS3kII9wARAQABiQJBBBgBAgErBQJTwBvCBRsMAAAAwF0gBBkBCAAGBQJTwBvB AAoJEJNgBqiYLw9VDRUIAJaTef6hsUAESnlGDpC+ymL2RZdzAJx9lXjU4hhaFcyhznuyyMJq d3mehmLxsqDRvHDiqyD71w2Bnc838MVZw0pwBPdnb/h9Ocmp0lL/9hwSGWvy4az5lYVyoA9u 14UIzh0YNGu6jr0isd/LJAbHXqwJwWWs3y8PTrpEp68V6lv+aXt5gR03lJEAvIR1Awp4JJ/e Z5y12gQISp0X8xal9YhhDWER92YLYrO2b6Hc2S31lAupzfCw8lmZsP1PRz1GmF/KmDD9J9N/ b8IehhWQqrBQjMjn2K2XkvN75HnAMHKFYfHZR3ZHtK52ZP1crV7THtbtrnPXVDq+vO4QPmdC +SEACgkQgTG1xCm8ZqC6BwgAl3kRh7oozpjpG8jpO8en5CBtTl3G+OpKJK9qbQyzdCsuJ0K1 qe1wZPZbP/Y+VtmqSgnExBzjStt9drjFBK8liPQZalp2sMlS9S7csSy6cMLF1auZubAZEqpm tpXagbtgR12YOo57Reb83F5KhtwwiWdoTpXRTx/nM0cHtjjrImONhP8OzVMmjem/B68NY++/ qt0F5XTsP2zjd+tRLrFh3W4XEcLt1lhYmNmbJR/l6+vVbWAKDAtcbQ8SL2feqbPWV6VDyVKh ya/EEq0xtf84qEB+4/+IjCdOzDD3kDZJo+JBkDnU3LBXw4WCw3QhOXY+VnhOn2EcREN7qdAK w0j9Sw== Message-ID: <44b0b277-713e-012f-a6cf-402c46a8d92b@gmail.com> Date: Wed, 13 Feb 2019 20:10:35 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <25e86edc-0b88-8c03-b692-776e971331f2@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/12/2019 10:56 AM, Heiner Kallweit wrote: > phylib enables interrupts before phy_start() has been called, and if > we receive an interrupt in a non-started state, the interrupt handler > returns IRQ_NONE. This causes problems with at least one Marvell chip > as reported by Andrew. > Fix this by handling interrupts the same as in phy_mac_interrupt(), > basically always running the phylib state machine. It knows when it > has to do something and when not. > This change allows to handle interrupts gracefully even if they > occur in a non-started state. > > Fixes: 2b3e88ea6528 ("net: phy: improve phy state checking") > Reported-by: Andrew Lunn > Signed-off-by: Heiner Kallweit Reviewed-by: Florian Fainelli -- Florian