From: Matthieu Baerts <matttbe@kernel.org>
To: Marco Elver <elver@google.com>
Cc: Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
kasan-dev@googlegroups.com, Netdev <netdev@vger.kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
linux-hardening@vger.kernel.org,
Kees Cook <keescook@chromium.org>,
the arch/x86 maintainers <x86@kernel.org>
Subject: Re: KFENCE: included in x86 defconfig?
Date: Wed, 7 Feb 2024 19:28:36 +0100 [thread overview]
Message-ID: <44dece0f-5dde-4bbd-a713-cb7db2654ba1@kernel.org> (raw)
In-Reply-To: <CANpmjNP==CANQi4_qFV_VVFDMsj1wHROxt3RKzwJBqo8_McCTg@mail.gmail.com>
Hi Marco,
Thank you for your reply!
On 07/02/2024 19:05, Marco Elver wrote:
> [Cc'ing a bunch more people to get input]
>
> Hi Matt,
>
> On Wed, 7 Feb 2024 at 17:16, Matthieu Baerts <matttbe@kernel.org> wrote:
> [...]
>> When talking to Jakub about the kernel config used by the new CI for the
>> net tree [1], Jakub suggested [2] to check if KFENCE could not be
>> enabled by default for x86 architecture.
>>
>> As KFENCE maintainers, what do you think about that? Do you see some
>> blocking points? Do you plan to add it in x86_64_defconfig?
>
> We have no concrete plans to add it to x86 defconfig. I don't think
> there'd be anything wrong with that from a technical point of view,
> but I think defconfig should remain relatively minimal.
>
> I guess different groups of people will disagree here: as kernel
> maintainers, it'd be a good thing because we get more coverage and
> higher probability of catching memory-safety bugs; as a user, I think
> having defconfig enable KFENCE seems unintuitive.
Thank you for having shared your point of view. I agree with you, the
x86_64_defconfig is probably not the right place.
> I think this would belong into some "hardening" config - while KFENCE
> is not a mitigation (due to sampling) it has the performance
> characteristics of unintrusive hardening techniques, so I think it
> would be a good fit. I think that'd be
> "kernel/configs/hardening.config".
>
> Preferences?
I didn't think about the hardening kconfig. It seems to make sense!
I will wait for people from the Linux Hardening ML to comment if that's
OK :)
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2024-02-07 18:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 16:16 KFENCE: included in x86 defconfig? Matthieu Baerts
2024-02-07 18:05 ` Marco Elver
2024-02-07 18:16 ` Borislav Petkov
2024-02-07 18:35 ` Matthieu Baerts
2024-02-07 19:04 ` Borislav Petkov
2024-02-07 22:12 ` Matthieu Baerts
2024-02-07 22:21 ` Marco Elver
2024-02-07 23:33 ` Jakub Kicinski
2024-02-08 7:47 ` Marco Elver
2024-02-08 10:55 ` Borislav Petkov
2024-02-08 11:11 ` Linus Torvalds
2024-02-08 11:12 ` Marco Elver
2024-02-08 12:01 ` Borislav Petkov
2024-02-07 18:28 ` Matthieu Baerts [this message]
2024-02-10 6:25 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44dece0f-5dde-4bbd-a713-cb7db2654ba1@kernel.org \
--to=matttbe@kernel.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).