From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodolfo Giometti Subject: Re: [PATCH -next] pps: using ERR_PTR instead of NULL while pps_register_source fails Date: Mon, 26 Nov 2018 11:43:06 +0100 Message-ID: <44edc27b-e679-24e8-aef1-fe5b7570f982@enneenne.com> References: <20181126102422.24028-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: YueHaibing , davem@davemloft.net, richardcochran@gmail.com, sudipm.mukherjee@gmail.com, gregkh@linuxfoundation.org Return-path: In-Reply-To: <20181126102422.24028-1-yuehaibing@huawei.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 26/11/2018 11:24, YueHaibing wrote: > pps_register_source() has keeps error codes in a local variable, > but it does not make use of the code. This patch let it return > the errcode in case of failure. > > Suggested-by: Richard Cochran > Signed-off-by: YueHaibing Acked-by: Rodolfo Giometti