netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: HELP - NETDEV WATCHDOG tx timeouts
Date: Fri, 08 Sep 2006 22:03:20 -0500	[thread overview]
Message-ID: <45022EF8.2020005@lwfinger.net> (raw)

In the bcm43xx driver, the code snippet shown below has a problem. When the synchronize_net 
statement is included, once every 200-300 passes through the code, the system will report a NETDEV 
WATCHDOG tx timeout for bcm43xx, even when the watchdog timeout is set to 30 sec. When the 
synchronize statement is removed, there are no errors, Except for lo, this is the only active 
network device on the system.

Is there something wrong with this structure? How can synchronize_net take that long?

Thanks, Larry

==============

        mutex_lock(...);
        netif_stop_queue(net_device);
        synchronize_net();               <================ problem ?
        spin_lock_irqsave(.....);
...... do some stuff on the hardware
        disable interrupts on device
        spin_unlock_irqrestore(.......);
        synchronize irq top/bottom halves
...... lengthy processing here
        spin_lock_irqsave(.....);
        tasklet_enable(.....);
        enable interrupts
...... more stuff with the hardware
        netif_wake_queue(net_device);
        spin_unlock_irqrestore(...);
        mutex_unlock(...);

                 reply	other threads:[~2006-09-09  3:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45022EF8.2020005@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).