From: Jeff Garzik <jgarzik@pobox.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: Zang Roy-r61911 <tie-fei.zang@freescale.com>,
Andrew Morton <akpm@osdl.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 3/3] Add tsi108 On Chip Ethernet device driver support
Date: Tue, 12 Sep 2006 10:43:21 -0400 [thread overview]
Message-ID: <4506C789.4050404@pobox.com> (raw)
In-Reply-To: <ada3bax2lzw.fsf@cisco.com>
Roland Dreier wrote:
> > +struct tsi108_prv_data {
> > + volatile u32 regs; /* Base of normal regs */
> > + volatile u32 phyregs; /* Base of register bank used for PHY access */
>
> Why volatile? This looks really wrong here.
Indeed.
> > + data->regs = (u32)ioremap(einfo->regs, 0x400); /*FIX ME */
> > + data->phyregs = (u32)ioremap(einfo->phyregs, 0x400); /*FIX ME */
>
> What needs to be fixed here? And why are you casting the result of
> ioremap to u32? Shouldn't you keep the normal return value?
Oh, that's very, very wrong.
Jeff
next prev parent reply other threads:[~2006-09-12 14:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <A0CDBA58F226D911B202000BDBAD46730A1B1410@zch01exm23.fsl.freescale.net>
[not found] ` <1157962200.10526.10.camel@localhost.localdomain>
2006-09-12 8:55 ` [patch 0/3] Add tsi108 On chip Ethernet device driver support Zang Roy-r61911
2006-09-21 4:04 ` [patch 0/3 v2] " Zang Roy-r61911
2006-09-12 8:55 ` [patch 1/3] Add tsi108 on Chip " Zang Roy-r61911
2006-09-21 4:04 ` [patch 1/3 v2] Add tsi108 On " Zang Roy-r61911
2006-09-12 8:55 ` [patch 3/3] " Zang Roy-r61911
2006-09-12 10:07 ` Arjan van de Ven
2006-09-19 7:39 ` Zang Roy-r61911
2006-09-20 8:45 ` Arjan van de Ven
2006-09-12 14:33 ` Roland Dreier
2006-09-12 14:43 ` Jeff Garzik [this message]
2006-09-14 2:51 ` Zang Roy-r61911
[not found] ` <1158749825.7973.9.camel@localhost.localdomain>
2006-09-21 4:26 ` Jeff Garzik
2006-09-21 5:46 ` Zang Roy-r61911
2006-09-21 6:30 ` Jeff Garzik
2006-09-21 4:46 ` Jeff Garzik
2006-09-29 7:36 ` Zang Roy-r61911
2006-09-29 7:47 ` Jeff Garzik
2006-10-17 7:18 ` Zang Roy-r61911
2006-10-30 5:19 ` Add tsi108/9 " Zang Roy-r61911
2006-10-31 2:26 ` [PATCH] " Zang Roy-r61911
2006-10-23 2:09 ` [patch 3/3] Add tsi108 " Zang Roy-r61911
2006-10-26 2:50 ` Zang Roy-r61911
2006-09-21 4:05 ` [patch 3/3 v2] " Zang Roy-r61911
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4506C789.4050404@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=tie-fei.zang@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).