* [PATCH] bcm43xx-softmac: improve wrong firmware message
@ 2006-09-12 20:29 Larry Finger
2006-09-12 21:49 ` Martin Langer
0 siblings, 1 reply; 5+ messages in thread
From: Larry Finger @ 2006-09-12 20:29 UTC (permalink / raw)
To: John Linville
Cc: netdev-u79uwXL29TY76Z2rM5mHXA, Bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w,
Michael Buesch, Stefano Brivio
An error message is changed to a printk as the original dprintk would
be optimized away if debugging were not enabled. If the error is triggered,
a more meaningful message is returned.
Signed-off-by: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
---
John,
This patch incorporates Michael's comments.
Larry
Index: wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
===================================================================
--- wireless-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_main.c
+++ wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
@@ -2405,9 +2405,10 @@ static int bcm43xx_chip_init(struct bcm4
BCM43xx_UCODE_TIME) & 0x1f);
if ( value16 > 0x128 ) {
- dprintk(KERN_ERR PFX
- "Firmware: no support for microcode rev > 0x128\n");
- err = -1;
+ printk(KERN_ERR PFX
+ "Firmware: no support for microcode extracted "
+ "from version 4.x binary drivers.\n");
+ err = -EOPNOTSUPP;
goto err_release_fw;
}
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] bcm43xx-softmac: improve wrong firmware message 2006-09-12 20:29 [PATCH] bcm43xx-softmac: improve wrong firmware message Larry Finger @ 2006-09-12 21:49 ` Martin Langer 2006-09-12 22:06 ` Larry Finger 0 siblings, 1 reply; 5+ messages in thread From: Martin Langer @ 2006-09-12 21:49 UTC (permalink / raw) To: Larry Finger Cc: John Linville, netdev, Bcm43xx-dev, Michael Buesch, Stefano Brivio On Tue, Sep 12, 2006 at 03:29:04PM -0500, Larry Finger wrote: > An error message is changed to a printk as the original dprintk would > be optimized away if debugging were not enabled. If the error is triggered, > a more meaningful message is returned. > > > if ( value16 > 0x128 ) { > - dprintk(KERN_ERR PFX > - "Firmware: no support for microcode rev > 0x128\n"); > - err = -1; > + printk(KERN_ERR PFX > + "Firmware: no support for microcode extracted " > + "from version 4.x binary drivers.\n"); Why not writing both (ucode rev and driver version)? Something like "from version 4.x binary drivers (rev>0x128).\n" BTW, if anybody needs the relationship between ucode revsion and driver version then he should look at the table here: http://www.langerland.de/linux/bcm43xx/firmware.html Martin ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] bcm43xx-softmac: improve wrong firmware message 2006-09-12 21:49 ` Martin Langer @ 2006-09-12 22:06 ` Larry Finger [not found] ` <45072F4D.80109-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org> 0 siblings, 1 reply; 5+ messages in thread From: Larry Finger @ 2006-09-12 22:06 UTC (permalink / raw) To: Martin Langer Cc: netdev-u79uwXL29TY76Z2rM5mHXA, Stefano Brivio, John Linville, Michael Buesch, Bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w Martin Langer wrote: > > Why not writing both (ucode rev and driver version)? Something like > > "from version 4.x binary drivers (rev>0x128).\n" > > BTW, if anybody needs the relationship between ucode revsion and driver > version then he should look at the table here: > > http://www.langerland.de/linux/bcm43xx/firmware.html I could do that; however, I think this error message may have a short life as I'm just now looking at Michael's v4 firmware revisions for d80211 with an eye toward porting them to softmac. John - what do you think? Larry ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <45072F4D.80109-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>]
* Re: [PATCH] bcm43xx-softmac: improve wrong firmware message [not found] ` <45072F4D.80109-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org> @ 2006-09-13 12:31 ` Michael Buesch 2006-09-14 14:00 ` John W. Linville 1 sibling, 0 replies; 5+ messages in thread From: Michael Buesch @ 2006-09-13 12:31 UTC (permalink / raw) To: Larry Finger Cc: netdev-u79uwXL29TY76Z2rM5mHXA, Martin Langer, Stefano Brivio, John Linville, Bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w On Wednesday 13 September 2006 00:06, Larry Finger wrote: > Martin Langer wrote: > > > > Why not writing both (ucode rev and driver version)? Something like > > > > "from version 4.x binary drivers (rev>0x128).\n" > > > > BTW, if anybody needs the relationship between ucode revsion and driver > > version then he should look at the table here: > > > > http://www.langerland.de/linux/bcm43xx/firmware.html > > I could do that; however, I think this error message may have a short life as > I'm just now looking at Michael's v4 firmware revisions for d80211 with an eye > toward porting them to softmac. Please note that it's incomplete. -- Greetings Michael. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] bcm43xx-softmac: improve wrong firmware message [not found] ` <45072F4D.80109-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org> 2006-09-13 12:31 ` Michael Buesch @ 2006-09-14 14:00 ` John W. Linville 1 sibling, 0 replies; 5+ messages in thread From: John W. Linville @ 2006-09-14 14:00 UTC (permalink / raw) To: Larry Finger Cc: netdev-u79uwXL29TY76Z2rM5mHXA, Martin Langer, Bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w, Michael Buesch, Stefano Brivio On Tue, Sep 12, 2006 at 05:06:05PM -0500, Larry Finger wrote: > Martin Langer wrote: > > > >Why not writing both (ucode rev and driver version)? Something like > > > > "from version 4.x binary drivers (rev>0x128).\n" > > > >BTW, if anybody needs the relationship between ucode revsion and driver > >version then he should look at the table here: > > > >http://www.langerland.de/linux/bcm43xx/firmware.html > > I could do that; however, I think this error message may have a short life > as I'm just now looking at Michael's v4 firmware revisions for d80211 with > an eye toward porting them to softmac. > > John - what do you think? Let's just take the new/current patch as-is. Someone who understands "rev > 0x128" should be able to find the message in the code for himself... :-) John -- John W. Linville linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-09-14 14:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-12 20:29 [PATCH] bcm43xx-softmac: improve wrong firmware message Larry Finger
2006-09-12 21:49 ` Martin Langer
2006-09-12 22:06 ` Larry Finger
[not found] ` <45072F4D.80109-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2006-09-13 12:31 ` Michael Buesch
2006-09-14 14:00 ` John W. Linville
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).