* mv643xx_eth: Unmap DMA buffers in receive path
@ 2006-09-12 18:22 Dale Farnsworth
2006-09-13 2:05 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Dale Farnsworth @ 2006-09-12 18:22 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev, Manish Lachwani
From: Dale Farnsworth <dale@farnsworth.org>
Fix a missing call to dma_unmap_single() in the receive path. Without
this call, errors have been observed on non-cache-coherent systems.
Signed-off-by Dale Farnsworth <dale@farnsworth.org>
---
drivers/net/mv643xx_eth.c | 2 ++
1 file changed, 2 insertions(+)
Index: linux-2.6.10/drivers/net/mv643xx_eth.c
===================================================================
--- linux-2.6.10.orig/drivers/net/mv643xx_eth.c
+++ linux-2.6.10/drivers/net/mv643xx_eth.c
@@ -402,6 +402,8 @@ static int mv643xx_eth_receive_queue(str
#else
while (eth_port_receive(mp, &pkt_info) == ETH_OK) {
#endif
+ dma_unmap_single(NULL, pkt_info.buf_ptr, RX_SKB_SIZE,
+ DMA_FROM_DEVICE);
mp->rx_desc_count--;
received_packets++;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mv643xx_eth: Unmap DMA buffers in receive path
2006-09-12 18:22 mv643xx_eth: Unmap DMA buffers in receive path Dale Farnsworth
@ 2006-09-13 2:05 ` Jeff Garzik
2006-09-13 16:21 ` PATCH " Dale Farnsworth
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2006-09-13 2:05 UTC (permalink / raw)
To: Dale Farnsworth; +Cc: netdev, Manish Lachwani
Dale Farnsworth wrote:
> From: Dale Farnsworth <dale@farnsworth.org>
>
> Fix a missing call to dma_unmap_single() in the receive path. Without
> this call, errors have been observed on non-cache-coherent systems.
>
> Signed-off-by Dale Farnsworth <dale@farnsworth.org>
>
> ---
>
> drivers/net/mv643xx_eth.c | 2 ++
> 1 file changed, 2 insertions(+)
ACK, but
[jgarzik@pretzel netdev-2.6]$ git-applymbox /g/tmp/mbox ~/info/signoff.txt
1 patch(es) to process.
Applying 'mv643xx_eth: Unmap DMA buffers in receive path'
error: patch failed: drivers/net/mv643xx_eth.c:402
error: drivers/net/mv643xx_eth.c: patch does not apply
^ permalink raw reply [flat|nested] 3+ messages in thread
* PATCH mv643xx_eth: Unmap DMA buffers in receive path
2006-09-13 2:05 ` Jeff Garzik
@ 2006-09-13 16:21 ` Dale Farnsworth
0 siblings, 0 replies; 3+ messages in thread
From: Dale Farnsworth @ 2006-09-13 16:21 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev, Manish Lachwani
From: Dale Farnsworth <dale@farnsworth.org>
Fix a missing call to dma_unmap_single() in the receive path. Without
this call, errors have been observed on non-cache-coherent systems.
Signed-off-by Dale Farnsworth <dale@farnsworth.org>
---
> ACK, but
> error: patch failed: drivers/net/mv643xx_eth.c:402
> error: drivers/net/mv643xx_eth.c: patch does not apply
Sorry. Patch was against an old version.
This one's current.
-Dale
drivers/net/mv643xx_eth.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
index 760c61b..eeab1df 100644
--- a/drivers/net/mv643xx_eth.c
+++ b/drivers/net/mv643xx_eth.c
@@ -385,6 +385,8 @@ static int mv643xx_eth_receive_queue(str
struct pkt_info pkt_info;
while (budget-- > 0 && eth_port_receive(mp, &pkt_info) == ETH_OK) {
+ dma_unmap_single(NULL, pkt_info.buf_ptr, RX_SKB_SIZE,
+ DMA_FROM_DEVICE);
mp->rx_desc_count--;
received_packets++;
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-09-13 16:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-12 18:22 mv643xx_eth: Unmap DMA buffers in receive path Dale Farnsworth
2006-09-13 2:05 ` Jeff Garzik
2006-09-13 16:21 ` PATCH " Dale Farnsworth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).