examples to model ethernet driver off of?

examples to model ethernet driver off of?

[Kumar Gala]

What are good examples of simple/basic ethernet drivers one should  
use to model a new driver off of?

thanks

- kumar

Re: examples to model ethernet driver off of?

[Francois Romieu]

Kumar Gala <galak@kernel.crashing.org> :
> What are good examples of simple/basic ethernet drivers one should  
> use to model a new driver off of?

tg3/bnx2/sky2/b44/8139cp

Shake, average, procrastinate.

It depends on what the hardware can do though.

-- 
Ueimor

Re: examples to model ethernet driver off of?

[Auke Kok]

Francois Romieu wrote:
> Kumar Gala <galak@kernel.crashing.org> :
>> What are good examples of simple/basic ethernet drivers one should  
>> use to model a new driver off of?
> 
> tg3/bnx2/sky2/b44/8139cp

Can I add e1000/ixgb to that? ;)

Cheers,

Auke

Re: examples to model ethernet driver off of?

[Kumar Gala]

On Sep 13, 2006, at 3:11 PM, Auke Kok wrote:

> Francois Romieu wrote:
>> Kumar Gala <galak@kernel.crashing.org> :
>>> What are good examples of simple/basic ethernet drivers one  
>>> should  use to model a new driver off of?
>> tg3/bnx2/sky2/b44/8139cp
>
> Can I add e1000/ixgb to that? ;)

What is the feeling about e100.c?

I'm looking for something that is just basic tx/rx with no real fancy  
features.

- k

Re: examples to model ethernet driver off of?

[Auke Kok]

Kumar Gala wrote:
> 
> On Sep 13, 2006, at 3:11 PM, Auke Kok wrote:
> 
>> Francois Romieu wrote:
>>> Kumar Gala <galak@kernel.crashing.org> :
>>>> What are good examples of simple/basic ethernet drivers one should  
>>>> use to model a new driver off of?
>>> tg3/bnx2/sky2/b44/8139cp
>>
>> Can I add e1000/ixgb to that? ;)
> 
> What is the feeling about e100.c?

e100 is a rather simple driver because the hardware doesn't support much 
features. We've tried to make e100 a bit more like e1000 over the last few 
years as in basic structure, and as such e1000 is always a bit ahead of e100 
when it comes to that. Nonetheless it's probably an easy driver to read 
codewise (I should hope).

Cheers,

Auke

Re: examples to model ethernet driver off of?

[Francois Romieu]

Kumar Gala <galak@kernel.crashing.org> :
[...]
> What is the feeling about e100.c?
> 
> I'm looking for something that is just basic tx/rx with no real fancy  
> features.

- a bit too much of 'if(' (missing space) and 'if (evil_statement'
- some 'return' which are not on a line of their own
- a few local variables could be added to avoid repeated foo->bar.baz[shnort]

But yes, it's quite nice.

-- 
Ueimor

Re: examples to model ethernet driver off of?

[Francois Romieu]

Auke Kok <auke-jan.h.kok@intel.com> :
[...]
> >tg3/bnx2/sky2/b44/8139cp
> 
> Can I add e1000/ixgb to that? ;)

Assume I have not noticed the smiley...

- $ grep int32 drivers/net/e1000/*
- $ grep ' if(' drivers/net/e1000/*
- tabs and spaces damage
- forward declarations (are not a substitute for documentation)
- static some_return_type
  e1000_shnortz(...

  I still use dumb grep

- wild return -EIO; in the middle of e1000_probe
- useless cast in e1000_probe::INIT_WORK() due to wrong prototype
  of e1000_reset_task().

It looks nicer than last time I poke my nose into it but I am not
completely sure that I would recommend it to a newcomer as the
climax of best practices or simplicity. Btw I do not remember if
it handles multi-page skb like everybody else either.

-- 
Ueimor

Re: examples to model ethernet driver off of?

[Stephen Hemminger]

On Wed, 13 Sep 2006 13:11:07 -0700
Auke Kok <auke-jan.h.kok@intel.com> wrote:

> Francois Romieu wrote:
> > Kumar Gala <galak@kernel.crashing.org> :
> >> What are good examples of simple/basic ethernet drivers one should  
> >> use to model a new driver off of?
> > 
> > tg3/bnx2/sky2/b44/8139cp
> 
> Can I add e1000/ixgb to that? ;)

sorry to pick on e1000, but the code is too verbose and
split over too many files.  The e100 code is much cleaner.

Re: examples to model ethernet driver off of?

[David Miller]

From: Stephen Hemminger <shemminger@osdl.org>
Date: Thu, 14 Sep 2006 10:26:10 +0900

> sorry to pick on e1000, but the code is too verbose and
> split over too many files.  The e100 code is much cleaner.

I totally agree, I would never use e1000 as a model
driver for someone writing some new code.