From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 04/23] e100: rework WoL and shutdown handling Date: Tue, 19 Sep 2006 15:10:58 -0400 Message-ID: <451040C2.5030005@pobox.com> References: <20060919172623.4605.56860.stgit@gitlost.site> <20060919172840.4605.33452.stgit@gitlost.site> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, "Brandeburg, Jesse" , "Kok, Auke" , "Ronciak, John" Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:48314 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S1751945AbWISTLB (ORCPT ); Tue, 19 Sep 2006 15:11:01 -0400 To: "Kok, Auke" In-Reply-To: <20060919172840.4605.33452.stgit@gitlost.site> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Kok, Auke wrote: > Unify our shutdown/suspend/resume code and make it similar to e1000: > e1000_shutdown now calls suspend which does the exact same thing on > shutdown except saving PCI config state on suspend. WoL setup code > is now also more simple and works even when CONFIG_PM is not set, which > was previously broken. > > Signed-off-by: Auke Kok Why does e100_suspend() need to exist even when CONFIG_PM is disabled? WoL is fundamentally power management. NAK. Jeff