From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 12/23] e1000: Maybe stop TX if not enough free descriptors Date: Tue, 19 Sep 2006 15:38:01 -0400 Message-ID: <45104719.9080708@pobox.com> References: <20060919172623.4605.56860.stgit@gitlost.site> <20060919172859.4605.60855.stgit@gitlost.site> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, "Brandeburg, Jesse" , "Kok, Auke" , "Ronciak, John" Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:14524 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S1751053AbWISTiD (ORCPT ); Tue, 19 Sep 2006 15:38:03 -0400 To: "Kok, Auke" In-Reply-To: <20060919172859.4605.60855.stgit@gitlost.site> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Actually, I rescind the ACK. The code should be inside a spinlock, and therefore not need this additional check. If this check were truly needed, then SMP code all over the kernel would be broken.