From mboxrd@z Thu Jan 1 00:00:00 1970 From: Auke Kok Subject: Re: [PATCH 04/23] e100: rework WoL and shutdown handling Date: Tue, 19 Sep 2006 13:25:45 -0700 Message-ID: <45105249.1070200@intel.com> References: <20060919172623.4605.56860.stgit@gitlost.site> <20060919172840.4605.33452.stgit@gitlost.site> <451040C2.5030005@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, "Brandeburg, Jesse" , "Kok, Auke" , "Ronciak, John" Return-path: Received: from mga01.intel.com ([192.55.52.88]:50723 "EHLO mga01.intel.com") by vger.kernel.org with ESMTP id S1751070AbWISU1X (ORCPT ); Tue, 19 Sep 2006 16:27:23 -0400 To: Jeff Garzik In-Reply-To: <451040C2.5030005@pobox.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Jeff Garzik wrote: > Kok, Auke wrote: >> Unify our shutdown/suspend/resume code and make it similar to e1000: >> e1000_shutdown now calls suspend which does the exact same thing on >> shutdown except saving PCI config state on suspend. WoL setup code >> is now also more simple and works even when CONFIG_PM is not set, which >> was previously broken. >> >> Signed-off-by: Auke Kok > > Why does e100_suspend() need to exist even when CONFIG_PM is disabled? > > WoL is fundamentally power management. same as e1000_suspend: we're consolidating shutdown code making 2 different codepaths exactly the same. e100_shutdown calls e100_suspend() in case of a normal powerdown. Auke