From: Jeff Garzik <jgarzik@pobox.com>
To: "Williams, Mitch A" <mitch.a.williams@intel.com>
Cc: netdev@vger.kernel.org, "Kok,
Auke-jan H" <auke-jan.h.kok@intel.com>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"Ronciak, John" <john.ronciak@intel.com>
Subject: Re: [PATCH 08/23] e1000: add multicast stats counters
Date: Wed, 20 Sep 2006 15:22:11 -0400 [thread overview]
Message-ID: <451194E3.3070107@pobox.com> (raw)
In-Reply-To: <F3EE2A9EB4576F40AFE238EC0AC04BC5091F8526@orsmsx402.amr.corp.intel.com>
Williams, Mitch A wrote:
>>> + { "rx_broadcast", E1000_STAT(stats.bprc) },
>>> + { "tx_broadcast", E1000_STAT(stats.bptc) },
>>> + { "rx_multicast", E1000_STAT(stats.mprc) },
>>> + { "tx_multicast", E1000_STAT(stats.mptc) },
>>> { "rx_errors", E1000_STAT(net_stats.rx_errors) },
>>> { "tx_errors", E1000_STAT(net_stats.tx_errors) },
>>> { "tx_dropped", E1000_STAT(net_stats.tx_dropped) },
>> NAK -- you also need to remove the standard net stats, which are
>> exported elsewhere
>
> Jeff, can you please explain the reason for this NAK a little more?
> Neither Auke nor I understand why you rejected the patch.
>
> This patch just adds the display of a few more stats in Ethtool. It
> doesn't affect any other counters, and is really just a convenience
> feature. I added this to the driver because of a customer request.
Adding those stats is fine. You guys just need to remove the existing
mess first.
Jeff
next prev parent reply other threads:[~2006-09-20 19:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-20 16:38 [PATCH 08/23] e1000: add multicast stats counters Williams, Mitch A
2006-09-20 19:22 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-09-20 23:50 cramerj
2006-09-21 0:47 ` Jeff Garzik
2006-09-27 20:09 ` Auke Kok
2006-09-19 17:26 [PATCH 00/23] e100, e1000, ixgb updates Kok, Auke
2006-09-19 17:28 ` [PATCH 08/23] e1000: add multicast stats counters Kok, Auke
2006-09-19 19:28 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=451194E3.3070107@pobox.com \
--to=jgarzik@pobox.com \
--cc=auke-jan.h.kok@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).