From: Paul Moore <paul.moore@hp.com>
To: Venkat Yekkirala <vyekkirala@TrustedCS.com>
Cc: netdev@vger.kernel.org, selinux@tycho.nsa.gov, jmorris@namei.org,
sds@tycho.nsa.gov, Chad Hanson <chanson@TrustedCS.com>
Subject: Re: [PATCH 7/7] secid reconciliation-v02: Enforcement for SELinux
Date: Wed, 20 Sep 2006 18:46:00 -0400 [thread overview]
Message-ID: <4511C4A8.2090709@hp.com> (raw)
In-Reply-To: <36282A1733C57546BE392885C061859201573267@chaos.tcs.tcs-sec.com>
Venkat Yekkirala wrote:
>>>+static int selinux_skb_policy_check(struct sk_buff *skb,
>>
>>unsigned short
>>
>>>family) +{
>>>+ u32 xfrm_sid, trans_sid;
>>>+ int err;
>>>+
>>>+ if (selinux_compat_net)
>>>+ return 1;
>>>+
>>>+ err = selinux_xfrm_decode_session(skb, &xfrm_sid, 0);
>>>+ BUG_ON(err);
>>
>>First, any reason against including the "struct sock *" in
>>the LSM hook? At a
>>quick glance it looks like it is available at each place
>>security_skb_policy_check() is invoked? If there are no
>>objections I would
>>like to see it included in the hook.
>
> There's no sock available (NULL) for forward, no-sock, time-wait cases, etc.
... which would be why I should have taken a closer look :)
> What you are trying to accomplish with the sock here anyway?
Actually this is no longer an issue because of something else - you can
ignore this now.
--
paul moore
linux security @ hp
next prev parent reply other threads:[~2006-09-20 22:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-20 21:08 [PATCH 7/7] secid reconciliation-v02: Enforcement for SELinux Venkat Yekkirala
2006-09-20 22:46 ` Paul Moore [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-09-18 19:15 Venkat Yekkirala
2006-09-08 16:50 Venkat Yekkirala
2006-09-18 18:37 ` James Morris
2006-09-18 18:55 ` James Morris
2006-09-18 22:26 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4511C4A8.2090709@hp.com \
--to=paul.moore@hp.com \
--cc=chanson@TrustedCS.com \
--cc=jmorris@namei.org \
--cc=netdev@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=vyekkirala@TrustedCS.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).