From: mabbas <mabbas@linux.intel.com>
To: Dan Williams <dcbw@redhat.com>
Cc: Jiri Benc <jbenc@suse.cz>, netdev@vger.kernel.org
Subject: Re: [PATCH 5/7] d80211: indicate if unassociate/radio off status
Date: Thu, 21 Sep 2006 13:39:18 -0700 [thread overview]
Message-ID: <4512F876.7000203@linux.intel.com> (raw)
In-Reply-To: <1158870634.5769.21.camel@localhost.localdomain>
Dan Williams wrote:
> On Thu, 2006-09-21 at 12:47 -0700, mabbas wrote:
>
>> Dan Williams wrote:
>>
>>> On Thu, 2006-09-21 at 19:01 +0200, Jiri Benc wrote:
>>>
>>>
>>>> On Mon, 28 Aug 2006 13:49:35 -0700, mabbas wrote:
>>>>
>>>>
>>>>> This patch indicate unassociated and radio off status
>>>>> in name field
>>>>>
>>>>>
>>>> NAK.
>>>>
>>>> Fix SIOCGIWAP handler instead.
>>>>
>>>>
>>> Right; the _one_ place anyone should ever have to check for unassociated
>>> status is SIOCGIWAP. That's it. Lets not put stuff in two different
>>> places. If it's all 0s, all 4s (stupid prism) or all Fs (i forget who
>>> does that), it's invalid and you're not connected.
>>>
>>> About the worst thing we can start doing is having to parse arbitrary
>>> strings to find out driver/card status. That's the same problem with
>>> "<hidden>" which hope DIES DIES DIES with d80211. If the AP is hidden,
>>> then it has a _blank_ SSID, not hacked to "<hidden>".
>>>
>>> For radio off, that may be a legitimate thing that's not covered in WE
>>> yet. But isn't that the domain of SIOCGIWPOWER, or is that just used to
>>> set PM modes and not return current status? [1]
>>>
>>> Dan
>>>
>>> [1] which would seem like an oversight to correct in nl80211
>>>
>>>
>>>
>> SIOCGIWPOWER is for power save mode it has nothing to do with radio off, we can
>> indicate radio off in txpower field i guess. I have question regarding SIOCGIWAP. if
>> I do #iwconfig ap 00:13:23:87:150:150, wont iwconfig always show 00:13:23:87:150:150
>> for SIOCGIWAP regardless if we associated or not? can we display blank in this case to
>> indicate not connected?
>>
>
> That's kind a hole in the WE API. In this case, I think, SIOCGIWAP
> should always return the BSSID of the current association, or none if
> there is no association.
>
> Doing an iwconfig ap xx:xx:xx:xx:xx:xx should make the driver internally
> locked to that BSSID, such that until you clear that lock, SIOCGIWAP
> should only show either that BSSID or 00:00:00:00:00:00. SIOCGIWAP
> should not return a valid BSSID when there is no association.
>
> Hopefully nl80211 can fix this omission in WE.
>
> Dan
>
I can fix the patch to do just that if we agree on that.
>
>> Mohamed
>>
>>
>>
>>
>>>> Jiri
>>>>
>>>>
>>>>
next prev parent reply other threads:[~2006-09-21 20:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-28 20:49 [PATCH 5/7] d80211: indicate if unassociate/radio off status mabbas
2006-08-28 21:17 ` Michael Wu
2006-08-29 17:55 ` Jouni Malinen
2006-08-29 22:28 ` Mohamed Abbas
2006-08-29 22:50 ` Michael Wu
2006-08-29 23:01 ` Michael Wu
2006-08-30 13:41 ` Dan Williams
2006-08-30 17:22 ` Michael Wu
2006-09-21 17:01 ` Jiri Benc
2006-09-21 19:03 ` Dan Williams
2006-09-21 19:47 ` mabbas
2006-09-21 20:30 ` Dan Williams
2006-09-21 20:39 ` mabbas [this message]
2006-09-21 22:38 ` Jiri Benc
2006-09-21 22:55 ` Jean Tourrilhes
2006-09-22 0:42 ` Jouni Malinen
2006-09-22 0:57 ` Jean Tourrilhes
2006-09-22 22:29 ` [d80211 patch 1/1] setting bss freq and phymode using rx_status mabbas
2006-09-25 16:16 ` Jiri Benc
2006-09-25 17:15 ` mabbas
2006-09-27 15:34 ` Jiri Benc
2006-09-22 8:32 ` [PATCH 5/7] d80211: indicate if unassociate/radio off status Johannes Berg
2006-09-22 14:05 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4512F876.7000203@linux.intel.com \
--to=mabbas@linux.intel.com \
--cc=dcbw@redhat.com \
--cc=jbenc@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).