* [PATCH] dsa: fix for_each_child.cocci warnings
@ 2021-07-11 16:12 Julia Lawall
2021-07-11 17:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2021-07-11 16:12 UTC (permalink / raw)
To: Alexander Lobakin
Cc: Vladimir Oltean, Florian Fainelli, Woojung Huh, UNGLinuxDriver,
Andrew Lunn, Vivien Didelot, Jakub Kicinski, netdev, linux-kernel,
kbuild-all, linux-kernel
From: kernel test robot <lkp@intel.com>
For_each_available_child_of_node should have of_node_put() before
return around line 423.
Generated by: scripts/coccinelle/iterators/for_each_child.cocci
CC: Alexander Lobakin <alobakin@pm.me>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: de5540965853e514a85d3b775e9049deb85a2ff3
commit: 227d72063fccb2d19b30fb4197fba478514f7d83 dsa: simplify Kconfig symbols and dependencies
:::::: branch date: 15 hours ago
:::::: commit date: 4 months ago
ksz_common.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/drivers/net/dsa/microchip/ksz_common.c
+++ b/drivers/net/dsa/microchip/ksz_common.c
@@ -419,8 +419,10 @@ int ksz_switch_register(struct ksz_devic
if (of_property_read_u32(port, "reg",
&port_num))
continue;
- if (!(dev->port_mask & BIT(port_num)))
+ if (!(dev->port_mask & BIT(port_num))) {
+ of_node_put(port);
return -EINVAL;
+ }
of_get_phy_mode(port,
&dev->ports[port_num].interface);
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dsa: fix for_each_child.cocci warnings
2021-07-11 16:12 [PATCH] dsa: fix for_each_child.cocci warnings Julia Lawall
@ 2021-07-11 17:10 ` patchwork-bot+netdevbpf
2021-07-11 21:20 ` Florian Fainelli
0 siblings, 1 reply; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-07-11 17:10 UTC (permalink / raw)
To: Julia Lawall
Cc: alobakin, olteanv, f.fainelli, woojung.huh, UNGLinuxDriver,
andrew, vivien.didelot, kuba, netdev, linux-kernel, kbuild-all
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Sun, 11 Jul 2021 18:12:56 +0200 (CEST) you wrote:
> From: kernel test robot <lkp@intel.com>
>
> For_each_available_child_of_node should have of_node_put() before
> return around line 423.
>
> Generated by: scripts/coccinelle/iterators/for_each_child.cocci
>
> [...]
Here is the summary with links:
- dsa: fix for_each_child.cocci warnings
https://git.kernel.org/netdev/net/c/84f7e0bb4809
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dsa: fix for_each_child.cocci warnings
2021-07-11 17:10 ` patchwork-bot+netdevbpf
@ 2021-07-11 21:20 ` Florian Fainelli
0 siblings, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2021-07-11 21:20 UTC (permalink / raw)
To: patchwork-bot+netdevbpf, Julia Lawall
Cc: alobakin, olteanv, woojung.huh, UNGLinuxDriver, andrew,
vivien.didelot, kuba, netdev, linux-kernel, kbuild-all
On 7/11/2021 10:10 AM, patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
>
> This patch was applied to netdev/net.git (refs/heads/master):
>
> On Sun, 11 Jul 2021 18:12:56 +0200 (CEST) you wrote:
>> From: kernel test robot <lkp@intel.com>
>>
>> For_each_available_child_of_node should have of_node_put() before
>> return around line 423.
>>
>> Generated by: scripts/coccinelle/iterators/for_each_child.cocci
>>
>> [...]
>
> Here is the summary with links:
> - dsa: fix for_each_child.cocci warnings
> https://git.kernel.org/netdev/net/c/84f7e0bb4809
The patch subject should have been:
net: dsa: microchip: fix for_each_child.cocci warning
(singular, not plural), yes I like to paint my bike shed blue.
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-11 21:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-11 16:12 [PATCH] dsa: fix for_each_child.cocci warnings Julia Lawall
2021-07-11 17:10 ` patchwork-bot+netdevbpf
2021-07-11 21:20 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).