netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Andrew Hall <andrew.hall@bluereefnetworks.com>
Cc: Stephen Hemminger <shemminger@osdl.org>, netdev@vger.kernel.org
Subject: Re: [PATCH 1/3] sky2: tx pause bug fix
Date: Thu, 21 Sep 2006 23:35:30 -0500	[thread overview]
Message-ID: <45136812.5060203@lwfinger.net> (raw)
In-Reply-To: <089101c6ddfd$20ba4320$0b00000a@bluereef.local>

Andrew Hall wrote:
> Unfortunately I spoke too soon.. :-(
> 
> The driver no longer appears to fail under load but still fails randomly 
> with relatively light load:
> 

I don't know if this will help, but NETDEV watchdog timeouts in the bcm43xx driver were fixed by 
changing a netif_stop_queue call into a netif_tx_disable. Why wrapping the stop_queue inside 
netif_tx_lock_bh/netif_tx_unlock_bh pairs works is beyond me, but ...

Larry

  reply	other threads:[~2006-09-22  4:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-06 19:44 [PATCH 1/3] sky2: tx pause bug fix Stephen Hemminger
2006-09-11  1:35 ` Andrew Hall
2006-09-19 20:31   ` Stephen Hemminger
2006-09-19 22:44     ` Andrew Hall
2006-09-22  4:11     ` Andrew Hall
2006-09-22  4:35       ` Larry Finger [this message]
2006-09-11 13:13 ` Jeff Garzik
2006-09-19 21:13   ` [PATCH] sky2: process tx pause frames Stephen Hemminger
2006-09-20 21:49     ` Jeff Garzik
2006-09-20 21:53       ` Stephen Hemminger
2006-09-13 17:28 ` [PATCH 1/3] sky2: tx pause bug fix Jeff Garzik
  -- strict thread matches above, loose matches on Subject: below --
2006-09-22  8:40 Andrew Hall
2006-09-22 17:27 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45136812.5060203@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=andrew.hall@bluereefnetworks.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).