netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jarek Poplawski <jarkao2@o2.pl>
Cc: Andrew Morton <akpm@osdl.org>,
	netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] [Bugme-new] [Bug 7179] New: Compilation of .tmp_linux1 fails due to missing declaration in net/netfilter/xt_physdev.c
Date: Fri, 22 Sep 2006 12:54:42 +0200	[thread overview]
Message-ID: <4513C0F2.1030107@trash.net> (raw)
In-Reply-To: <20060922105122.GA12425@ff.dom.local>

Jarek Poplawski wrote:
> On Fri, Sep 22, 2006 at 12:15:43PM +0200, Patrick McHardy wrote:
> ...
> 
>>We should fix the physdev dependencies since this is what is causing
>>problems.
> 
> ...
> 
>> config NETFILTER_XT_MATCH_PHYSDEV
>> 	tristate '"physdev" match support'
>>-	depends on NETFILTER_XTABLES && BRIDGE_NETFILTER
>>+	depends on NETFILTER_XTABLES && BRIDGE && BRIDGE_NETFILTER
> 
> 
> Sure! But someone may ask what for BRIDGE_NETFILTER depends
> on BRIDGE if you should repeat this? 

Simply because it really depends on BRIDGE. The reason why we need
BRIDGE as dependency here also is because BRIDGE_NETFILTER is a
boolean, but may still result in a module because of special
logic in the bridge makefile.



  reply	other threads:[~2006-09-22 10:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-21 22:37 Fw: [Bugme-new] [Bug 7179] New: Compilation of .tmp_linux1 fails due to missing declaration in net/netfilter/xt_physdev.c Andrew Morton
2006-09-22  8:41 ` Jarek Poplawski
2006-09-22  9:27   ` Jarek Poplawski
2006-09-22  9:55     ` [PATCH] " Jarek Poplawski
2006-09-22 10:15       ` Patrick McHardy
2006-09-22 10:51         ` Jarek Poplawski
2006-09-22 10:54           ` Patrick McHardy [this message]
2006-09-22 11:48             ` Jarek Poplawski
2006-09-22 11:58               ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4513C0F2.1030107@trash.net \
    --to=kaber@trash.net \
    --cc=akpm@osdl.org \
    --cc=davem@davemloft.net \
    --cc=jarkao2@o2.pl \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).