From: Eddie Kohler <kohler@cs.ucla.edu>
To: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Cc: Ian McDonald <ian.mcdonald@jandi.co.nz>,
Arnaldo de Melo <acme@mandriva.com>,
David Miller <davem@davemloft.net>,
"dccp (vger)" <dccp@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 6/7] [DCCP]: Fix setting of packet size in CCID3
Date: Fri, 22 Sep 2006 09:57:57 -0700 [thread overview]
Message-ID: <45141615.30908@cs.ucla.edu> (raw)
In-Reply-To: <200609221151.57230@strip-the-willow>
> | + case DCCP_SOCKOPT_TX_PACKET_SIZE:
> | + if (dmsk->dccpms_tx_ccid != DCCPC_CCID3)
> | + err = -EINVAL;
> This is unfortunate: it is in the generic dccp code but
> works only for CCID 3. Same for DCCP_SOCKOPT_RX_PACKET_SIZE.
I agree with Gerrit. An average packet size congestion control parameter
might be useful for multiple CCIDs, even if only some CCIDs would use it.
Would prefer that this sets the parameter in all cases.
E
>
>
> --Gerrit
> -
> To unsubscribe from this list: send the line "unsubscribe dccp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2006-09-22 16:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-22 2:32 [PATCH 6/7] [DCCP]: Fix setting of packet size in CCID3 Ian McDonald
2006-09-22 10:51 ` Gerrit Renker
2006-09-22 16:57 ` Eddie Kohler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45141615.30908@cs.ucla.edu \
--to=kohler@cs.ucla.edu \
--cc=acme@mandriva.com \
--cc=davem@davemloft.net \
--cc=dccp@vger.kernel.org \
--cc=gerrit@erg.abdn.ac.uk \
--cc=ian.mcdonald@jandi.co.nz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).