netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Netdev List <netdev@vger.kernel.org>
Subject: Re: [CRYPTO] api: Feed flag directly to crypto_yield
Date: Fri, 22 Sep 2006 18:16:14 -0400	[thread overview]
Message-ID: <451460AE.2080200@garzik.org> (raw)
In-Reply-To: <200609222104.k8ML4JE4025619@hera.kernel.org>

Linux Kernel Mailing List wrote:
> diff --git a/crypto/internal.h b/crypto/internal.h
> index b110b97..7dc04ef 100644
> --- a/crypto/internal.h
> +++ b/crypto/internal.h
> @@ -67,9 +67,9 @@ static inline void crypto_kunmap(void *v
>  	kunmap_atomic(vaddr, crypto_kmap_type(out));
>  }
>  
> -static inline void crypto_yield(struct crypto_tfm *tfm)
> +static inline void crypto_yield(u32 flags)
>  {
> -	if (tfm->crt_flags & CRYPTO_TFM_REQ_MAY_SLEEP)
> +	if (flags & CRYPTO_TFM_REQ_MAY_SLEEP)
>  		cond_resched();
>  }

I would add "else cpu_relax()"

	Jeff



           reply	other threads:[~2006-09-22 22:16 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <200609222104.k8ML4JE4025619@hera.kernel.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=451460AE.2080200@garzik.org \
    --to=jeff@garzik.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).