Re: [patch 02/11] 3x59x: fix PCI resource management

[Jeff Garzik <jeff@garzik.org>]

akpm@osdl.org wrote:
> From: Jeff Garzik <jgarzik@pobox.com>
> 
> The driver wrongly claimed I/O ports at an address returned by pci_iomap()
> -- even if it was passed an MMIO address.  Fix this by claiming/releasing
> all PCI resources in the PCI driver probe/remove handlers instead and get
> rid of the must_free_region flag weirdness (why would Cardbus claim
> anything for us?).
> 
> Also, the remove handler was trying to talk to the chip after having
> disabled its address decoders (at least on x86) -- fix this and get rid of
> useless VORTEX_PCI() calls.
> 
> While at it, fix some cases of the overly indented code...
> 
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> Cc: Jeff Garzik <jgarzik@pobox.com>
> 
> - Would prefer that vortex_init_one() do the `goto out_release;' thing
>   rather than having multiple cleanup-then-return points.
> 
> - I don't remember the story with cardbus either.  Presumably once upon a
>   time the cardbus layer was claiming IO regions on behalf of cardbus
>   devices (?)
> 
> Signed-off-by: Andrew Morton <akpm@osdl.org>

ACK + HOLD, waiting to see if someone actually tested it