From: Patrick McHardy <kaber@trash.net>
To: Thomas Graf <tgraf@suug.ch>
Cc: "Nordlund Kim (Nokia-NET/Helsinki)" <Kim.Nordlund@nokia.com>,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PKT_SCHED] cls_basic: Use unsigned int when generating handle
Date: Wed, 27 Sep 2006 11:44:47 +0200 [thread overview]
Message-ID: <451A480F.7050404@trash.net> (raw)
In-Reply-To: <20060927093301.GY18349@postel.suug.ch>
Thomas Graf wrote:
> * Nordlund Kim (Nokia-NET/Helsinki) <Kim.Nordlund@nokia.com> 2006-09-27 11:50
>
>>So I would suggest to apply this patch to be compatible with the
>>GCC version in RHEL5, and simply to make code clearer (to the
>>intended idea).
>
>
> Yes.
I don't care much about this small change, but I think bugs
should be fixed where they originate. If RH's gcc miscompiles
this with -Os I wouldn't trust it anyway, and the easy way to
fix it seems to be to deactivate CONFIG_CC_OPTIMIZE_FOR_SIZE,
which even includes a big warning of broken compilers.
What about the similar code in u32 and cbq?
next prev parent reply other threads:[~2006-09-27 9:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-26 11:59 [PKT_SCHED] cls_basic: Use unsigned int when generating handle Thomas Graf
2006-09-26 13:32 ` Patrick McHardy
2006-09-26 18:36 ` Thomas Graf
2006-09-27 8:50 ` Nordlund Kim (Nokia-NET/Helsinki)
2006-09-27 9:33 ` Thomas Graf
2006-09-27 9:44 ` Patrick McHardy [this message]
2006-09-27 10:09 ` Thomas Graf
2006-09-27 11:45 ` Nordlund Kim (Nokia-NET/Helsinki)
2006-09-27 23:18 ` David Miller
2006-09-27 23:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=451A480F.7050404@trash.net \
--to=kaber@trash.net \
--cc=Kim.Nordlund@nokia.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).