From: Jeff Garzik <jeff@garzik.org>
To: Michael Chan <mchan@broadcom.com>
Cc: davem@davemloft.net, linville@tuxdriver.com, netdev@vger.kernel.org
Subject: Re: [PATCH 5/9][TG3]: Add tg3_poll_fw().
Date: Wed, 27 Sep 2006 16:47:02 -0400 [thread overview]
Message-ID: <451AE346.9010801@garzik.org> (raw)
In-Reply-To: <1159389289.3411.22.camel@rh4>
Michael Chan wrote:
> + /* Chip might not be fitted with firmware. Some Sun onboard
> + * parts are configured like that. So don't signal the timeout
> + * of the above loop as an error, but do report the lack of
> + * running firmware once.
> + */
> + if (i >= 100000 &&
> + !(tp->tg3_flags2 & TG3_FLG2_NO_FWARE_REPORTED)) {
> + tp->tg3_flags2 |= TG3_FLG2_NO_FWARE_REPORTED;
> +
> + printk(KERN_INFO PFX "%s: No firmware running.\n",
> + tp->dev->name);
> + }
> +
> + return 0;
You need to actually return failure, for the failure case.
Currently, this function is written to return an error code, but always
returns zero.
Jeff
next prev parent reply other threads:[~2006-09-27 20:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-27 20:34 [PATCH 5/9][TG3]: Add tg3_poll_fw() Michael Chan
2006-09-27 20:47 ` Jeff Garzik [this message]
2006-09-27 20:49 ` Michael Chan
2006-09-27 23:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=451AE346.9010801@garzik.org \
--to=jeff@garzik.org \
--cc=davem@davemloft.net \
--cc=linville@tuxdriver.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).