From: Jeff Garzik <jgarzik@pobox.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ethtool: add sky2 register dump
Date: Wed, 27 Sep 2006 18:01:21 -0400 [thread overview]
Message-ID: <451AF4B1.2000208@pobox.com> (raw)
In-Reply-To: <20060926115437.11ed1f85@freekitty>
Stephen Hemminger wrote:
> Add support for sky2 register dump, put it in a common file
> for both skge and sky2.
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
You should know this by now: separate out logical changes into multiple
patches.
When renaming a file AND making changes to it, your changes are
completely obscured by the rename.
First patch should do the rename, but not change existing code. Second
patch should include any code updates you wish to make.
ACK changes, NAK in present form.
next prev parent reply other threads:[~2006-09-27 22:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-26 18:54 [PATCH] ethtool: add sky2 register dump Stephen Hemminger
2006-09-27 22:01 ` Jeff Garzik [this message]
2006-09-26 20:08 ` [PATCH 1/4] ethtool: move skge.c to marvell.c Stephen Hemminger
2006-09-27 23:03 ` Jeff Garzik
2006-09-26 20:09 ` [PATCH 2/4] ethtool: sky2 support Stephen Hemminger
2006-09-26 20:10 ` [PATCH 3/4] ethtool: don't show sync queue's on skge/sky2 Stephen Hemminger
2006-09-27 23:03 ` Jeff Garzik
2006-09-27 22:34 ` Stephen Hemminger
2006-09-27 23:19 ` Jeff Garzik
2006-09-26 20:10 ` [PATCH 4/4] ethtool: spelling fix Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=451AF4B1.2000208@pobox.com \
--to=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).