From: Stephen Hemminger <shemminger@osdl.org>
To: David Miller <davem@davemloft.net>
Cc: jgarzik@pobox.com, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] loopback: minor statistics optimization
Date: Wed, 27 Sep 2006 20:13:14 -0700 [thread overview]
Message-ID: <451B3DCA.9010407@osdl.org> (raw)
In-Reply-To: <20060927.200459.13769170.davem@davemloft.net>
David Miller wrote:
> From: Stephen Hemminger <shemminger@osdl.org>
> Date: Fri, 8 Sep 2006 11:20:56 -0700
>
>
>> Minor loopback enhancements for 2.6.19
>>
>> The loopback device status structure is a singleton and doesn't
>> need to be allocated. Add ethtool_ops hooks to show checksum always on,
>> and make ethtool_ops const.
>>
>> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
>>
>
> The ethtool bits are OK, but putting the loopback stats into
> the image adds nearly 200 bytes of .data section space on
> 64-bit.
>
> I don't really think it's that big of a deal to avoid the
> kmalloc() call.
>
Yeah but doing the kmalloc is going to get a bigger chunk (rounded up),
anyway. The statistics should show up in BSS so it won't add to kernel size.
next prev parent reply other threads:[~2006-09-28 3:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-08 18:16 [PATCH 1/2] ethtool: allow const ethtool_ops Stephen Hemminger
2006-09-08 18:20 ` [PATCH 2/2] loopback: minor statistics optimization Stephen Hemminger
2006-09-28 3:04 ` David Miller
2006-09-28 3:13 ` Stephen Hemminger [this message]
2006-09-28 3:25 ` David Miller
2006-09-12 16:08 ` [PATCH 1/2] ethtool: allow const ethtool_ops Jeff Garzik
2006-09-13 2:08 ` Stephen Hemminger
2006-09-13 2:12 ` Jeff Garzik
2006-09-13 2:19 ` Stephen Hemminger
2006-09-13 5:09 ` Stephen Hemminger
2006-09-13 6:00 ` Jeff Garzik
2006-09-13 17:45 ` Jeff Garzik
2006-09-14 1:54 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=451B3DCA.9010407@osdl.org \
--to=shemminger@osdl.org \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).