From: Larry Finger <Larry.Finger@lwfinger.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: linville@tuxdriver.com, netdev@vger.kernel.org
Subject: Re: [PATCH] softmac: Fix WX and association related races
Date: Wed, 27 Sep 2006 23:09:26 -0500 [thread overview]
Message-ID: <451B4AF6.3090203@lwfinger.net> (raw)
In-Reply-To: <200609271950.47430.mb@bu3sch.de>
Michael Buesch wrote:
> On Wednesday 27 September 2006 18:18, Larry Finger wrote:
>> Michael Buesch wrote:
>>> This fixes some race conditions in the WirelessExtension
>>> handling and association handling code.
>>>
>>> Signed-off-by: Michael Buesch <mb@bu3sch.de>
>>>
>>> ---
>> This patch doesn't apply.
>
> Oh, linville merged stuff on the 25th. That's the day I updated
> my tree to do this patch. But seems like I did it just before
> the merge.
> Who could suspect that linville merges something. :D
> *me runs away*
>
> Anyway. Here's an updated patch.
NACK this version. It applied correctly, but introduced a new problem. My device occasionally gets
deauthentication messages from my AP.Preciously, it would do a scan or two, and then reauthenticate.
After your patch was applied, it never stops scanning.
The "normal" sequence is
kernel: SoftMAC: Received deauthentication packet from 00:14:bf:85:49:fa, but that network is unknown.
kernel: SoftMAC: Associate: Scanning for networks first.
kernel: SoftMAC: Start scanning with channel: 1
kernel: SoftMAC: Scanning 14 channels
kernel: bcm43xx: set security called, .enabled = 0, .encrypt = 0
kernel: bcm43xx: set security called, .enabled = 0, .encrypt = 0
kernel: bcm43xx: set security called, .level = 0, .enabled = 0, .encrypt = 0
kernel: bcm43xx: set security called, .level = 0, .enabled = 0, .encrypt = 0
kernel: bcm43xx: set security called, .level = 0, .enabled = 0, .encrypt = 0
kernel: SoftMAC: Scanning finished
kernel: SoftMAC: Queueing Authentication Request to 00:14:bf:85:49:fa
kernel: SoftMAC: Cannot associate without being authenticated, requested authentication
kernel: SoftMAC: Sent Authentication Request to 00:14:bf:85:49:fa.
kernel: SoftMAC: Open Authentication completed with 00:14:bf:85:49:fa
kernel: SoftMAC: sent association request!
kernel: SoftMAC: generic IE set to dd160050f20101000050f20201000050f20201000050f202
kernel: SoftMAC: Already associating or associated to 00:14:bf:85:49:fa
kernel: SoftMAC: associated!
kernel: bcm43xx: set security called, .active_key = 0, .level = 2, .enabled = 1,
With your patch:
kernel: SoftMAC: Received deauthentication packet from 00:14:bf:85:49:fa, but that network is unknown.
kernel: SoftMAC: Scanning finished
kernel: SoftMAC: Unable to find matching network after scan!
kernel: SoftMAC: Associate: Scanning for networks first.
kernel: SoftMAC: Start scanning with channel: 1
kernel: SoftMAC: Scanning 14 channels
kernel: SoftMAC: Scanning finished
kernel: SoftMAC: Associate: Scanning for networks first.
kernel: SoftMAC: Start scanning with channel: 1
kernel: SoftMAC: Scanning 14 channels
kernel: SoftMAC: Scanning finished
kernel: SoftMAC: Associate: Scanning for networks first.
kernel: SoftMAC: Start scanning with channel: 1
kernel: SoftMAC: Scanning 14 channels
kernel: SoftMAC: Scanning finished
kernel: SoftMAC: Unable to find matching network after scan!
kernel: SoftMAC: generic IE set to dd160050f20101000050f20201000050f20201000050f202
kernel: SoftMAC: Associate: Scanning for networks first.
kernel: SoftMAC: Start scanning with channel: 1
kernel: SoftMAC: Scanning 14 channels
kernel: SoftMAC: Scanning finished
kernel: SoftMAC: Associate: Scanning for networks first.
kernel: SoftMAC: Start scanning with channel: 1
kernel: SoftMAC: Scanning 14 channels
kernel: SoftMAC: Scanning finished
kernel: SoftMAC: Associate: Scanning for networks first.
kernel: SoftMAC: Start scanning with channel: 1
kernel: SoftMAC: Scanning 14 channels
kernel: SoftMAC: Scanning finished
kernel: SoftMAC: Unable to find matching network after scan!
kernel: SoftMAC: generic IE set to dd160050f20101000050f20201000050f20201000050f202
This pattern repeats until the network is brought down and back up.
Larry
next prev parent reply other threads:[~2006-09-28 4:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-27 15:26 [PATCH] softmac: Fix WX and association related races Michael Buesch
2006-09-27 16:18 ` Larry Finger
2006-09-27 17:50 ` Michael Buesch
2006-09-27 21:11 ` Christian
2006-09-27 21:21 ` Christian
2006-09-27 22:23 ` Benjamin Herrenschmidt
2006-09-28 0:43 ` Larry Finger
2006-09-28 1:04 ` Benjamin Herrenschmidt
2006-09-28 4:09 ` Larry Finger [this message]
2006-09-28 12:55 ` Michael Buesch
2006-09-28 14:19 ` Dan Williams
2006-09-28 14:27 ` Johannes Berg
2006-09-28 14:37 ` Dan Williams
2006-09-28 14:43 ` Michael Buesch
2006-09-28 14:52 ` Dan Williams
2006-09-28 15:13 ` Michael Buesch
2006-09-28 17:33 ` Jouni Malinen
2006-09-28 15:16 ` Larry Finger
2006-09-28 15:29 ` Michael Buesch
2006-09-28 15:35 ` Michael Wu
2006-09-28 15:52 ` Larry Finger
2006-09-28 16:31 ` Jason Lunz
2006-09-28 17:04 ` Larry Finger
2006-09-28 17:14 ` Michael Buesch
2006-09-28 17:40 ` Larry Finger
2006-09-28 14:43 ` Johannes Berg
2006-09-27 22:20 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=451B4AF6.3090203@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).