* [PATCH] bcm43xx-softmac: fix warning from ignoring returned value from pci_enable_device
@ 2006-09-28 5:10 Larry Finger
2006-09-28 7:26 ` Ian McDonald
0 siblings, 1 reply; 3+ messages in thread
From: Larry Finger @ 2006-09-28 5:10 UTC (permalink / raw)
To: John Linville
Cc: netdev-u79uwXL29TY76Z2rM5mHXA, Bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w,
Michael Buesch, Stefano Brivio
Linus's tree now has a configuration option that prints a warning whenever
the returned value of any routine is ignored. This patch fixes the only such
warning for bcm43xx.
Signed-off-by: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
---
Index: linux-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
===================================================================
--- linux-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_main.c
+++ linux-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
@@ -4208,7 +4207,11 @@ static int bcm43xx_resume(struct pci_dev
dprintk(KERN_INFO PFX "Resuming...\n");
pci_set_power_state(pdev, 0);
- pci_enable_device(pdev);
+ err = pci_enable_device(pdev);
+ if (err) {
+ printk(KERN_ERR PFX "Failure with pci_enable_device!\n");
+ return err;
+ }
pci_restore_state(pdev);
bcm43xx_chipset_attach(bcm);
---
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] bcm43xx-softmac: fix warning from ignoring returned value from pci_enable_device
2006-09-28 5:10 [PATCH] bcm43xx-softmac: fix warning from ignoring returned value from pci_enable_device Larry Finger
@ 2006-09-28 7:26 ` Ian McDonald
2006-09-28 13:47 ` Larry Finger
0 siblings, 1 reply; 3+ messages in thread
From: Ian McDonald @ 2006-09-28 7:26 UTC (permalink / raw)
To: Larry Finger
Cc: John Linville, Michael Buesch, netdev, Bcm43xx-dev,
Stefano Brivio
On 9/28/06, Larry Finger <Larry.Finger@lwfinger.net> wrote:
> Linus's tree now has a configuration option that prints a warning whenever
> the returned value of any routine is ignored. This patch fixes the only such
> warning for bcm43xx.
>
Can you tell me how to make this check please so I can check my code
in the kernel? I could look it up but obviously you can tell me
quickly :-)
Regards,
Ian
--
Ian McDonald
Web: http://wand.net.nz/~iam4
Blog: http://imcdnzl.blogspot.com
WAND Network Research Group
Department of Computer Science
University of Waikato
New Zealand
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bcm43xx-softmac: fix warning from ignoring returned value from pci_enable_device
2006-09-28 7:26 ` Ian McDonald
@ 2006-09-28 13:47 ` Larry Finger
0 siblings, 0 replies; 3+ messages in thread
From: Larry Finger @ 2006-09-28 13:47 UTC (permalink / raw)
To: Ian McDonald
Cc: John Linville, Michael Buesch, netdev, Bcm43xx-dev,
Stefano Brivio
Ian McDonald wrote:
> On 9/28/06, Larry Finger <Larry.Finger@lwfinger.net> wrote:
>> Linus's tree now has a configuration option that prints a warning
>> whenever
>> the returned value of any routine is ignored. This patch fixes the
>> only such
>> warning for bcm43xx.
>>
> Can you tell me how to make this check please so I can check my code
> in the kernel? I could look it up but obviously you can tell me
> quickly :-)
It is the ENABLE_MUST_CHECK option that appeared with the 2.6.18-gitX updates in Linus's tree, where
I think X was 4 or 6. When this was turned on, there were a LOT of new warnings.
Larry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-09-28 13:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-28 5:10 [PATCH] bcm43xx-softmac: fix warning from ignoring returned value from pci_enable_device Larry Finger
2006-09-28 7:26 ` Ian McDonald
2006-09-28 13:47 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).