From: Jeff Garzik <jgarzik@pobox.com>
To: Michael Chan <mchan@broadcom.com>
Cc: Stephen Hemminger <shemminger@osdl.org>, netdev@vger.kernel.org
Subject: Re: [RFC] let mortals use ethtool
Date: Thu, 28 Sep 2006 16:28:08 -0400 [thread overview]
Message-ID: <451C3058.8000903@pobox.com> (raw)
In-Reply-To: <1159474625.3741.6.camel@rh4>
Michael Chan wrote:
> On Thu, 2006-09-28 at 12:25 -0700, Stephen Hemminger wrote:
>
>> + /* Allow some commands to be done by anyone */
>> + switch(ethcmd) {
>> + case ETHTOOL_GSET:
>> + case ETHTOOL_GDRVINFO:
>> + case ETHTOOL_GREGS:
>> + case ETHTOOL_GWOL:
>> + case ETHTOOL_GMSGLVL:
>> + case ETHTOOL_GLINK:
>> + case ETHTOOL_GCOALESCE:
>> + case ETHTOOL_GRINGPARAM:
>> + case ETHTOOL_GPAUSEPARAM:
>> + case ETHTOOL_GRXCSUM:
>> + case ETHTOOL_GTXCSUM:
>> + case ETHTOOL_GSG:
>> + case ETHTOOL_GSTRINGS:
>> + case ETHTOOL_PHYS_ID:
>> + case ETHTOOL_GSTATS:
>> + case ETHTOOL_GTSO:
>> + case ETHTOOL_GPERMADDR:
>> + case ETHTOOL_GUFO:
>> + case ETHTOOL_GGSO:
>
> I'm against letting normal users do ETHTOOL_GREGS and ETHTOOL_PHYS_ID.
> Dumping 64K worth of registers and blinking the LEDs should be
> restricted. But I have no problem doing these checks in the driver if
> necessary.
It is because of issues like these that we should not open up the entire
list above, all at once. Each sub-ioctl needs careful consideration and
driver auditing.
Jeff
next prev parent reply other threads:[~2006-09-28 20:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 19:25 [RFC] let mortals use ethtool Stephen Hemminger
2006-09-28 19:53 ` James Morris
2006-09-28 20:43 ` Jeff Garzik
2006-09-28 19:56 ` Auke Kok
2006-09-28 21:53 ` David Miller
2006-09-28 22:03 ` Michael Chan
2006-09-28 22:22 ` David Miller
2006-09-28 20:17 ` Michael Chan
2006-09-28 20:28 ` Jeff Garzik [this message]
2006-09-28 20:32 ` James Morris
2006-09-28 20:35 ` Jeff Garzik
2006-09-28 20:39 ` Michael Chan
2006-09-28 22:16 ` David Miller
2006-09-28 22:30 ` Jeff Garzik
2006-09-28 22:13 ` David Miller
2006-09-28 22:25 ` Jeff Garzik
2006-09-28 22:33 ` David Miller
2006-09-28 20:23 ` Jeff Garzik
2006-09-28 22:15 ` David Miller
2006-09-28 22:41 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=451C3058.8000903@pobox.com \
--to=jgarzik@pobox.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).