netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: David Miller <davem@davemloft.net>
Cc: jmorris@namei.org, mchan@broadcom.com, shemminger@osdl.org,
	netdev@vger.kernel.org
Subject: Re: [RFC] let mortals use ethtool
Date: Thu, 28 Sep 2006 18:30:50 -0400	[thread overview]
Message-ID: <451C4D1A.7010206@pobox.com> (raw)
In-Reply-To: <20060928.151649.71167157.davem@davemloft.net>

David Miller wrote:
> Secondarily, looping over reading all of the registers of the chip
> might kill performance since the IO accesses compete with the
> normal packet sending/receiving operations.

This can be true of any ethtool sub-ioctl that beats the registers, if 
run in a tight loop.  PHYs are particularly nasty, because outside of 
hardware problems mentioned in the previous email, many phy read 
routines contain a metric ton of udelay() and mdelay()s.  Now, an 
unpriv'd user can cause the kernel to do tons of in-kernel busy-waits, 
in effect spinning the CPU at their mercy.

	Jeff



  reply	other threads:[~2006-09-28 22:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-28 19:25 [RFC] let mortals use ethtool Stephen Hemminger
2006-09-28 19:53 ` James Morris
2006-09-28 20:43   ` Jeff Garzik
2006-09-28 19:56 ` Auke Kok
2006-09-28 21:53   ` David Miller
2006-09-28 22:03     ` Michael Chan
2006-09-28 22:22       ` David Miller
2006-09-28 20:17 ` Michael Chan
2006-09-28 20:28   ` Jeff Garzik
2006-09-28 20:32   ` James Morris
2006-09-28 20:35     ` Jeff Garzik
2006-09-28 20:39       ` Michael Chan
2006-09-28 22:16     ` David Miller
2006-09-28 22:30       ` Jeff Garzik [this message]
2006-09-28 22:13   ` David Miller
2006-09-28 22:25     ` Jeff Garzik
2006-09-28 22:33       ` David Miller
2006-09-28 20:23 ` Jeff Garzik
2006-09-28 22:15   ` David Miller
2006-09-28 22:41   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=451C4D1A.7010206@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=davem@davemloft.net \
    --cc=jmorris@namei.org \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).