netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* another ATM bug
@ 2006-10-01 13:34 Jeff Garzik
  2006-10-01 15:03 ` Mitchell Blank Jr
  0 siblings, 1 reply; 2+ messages in thread
From: Jeff Garzik @ 2006-10-01 13:34 UTC (permalink / raw)
  To: chas williams - CONTRACTOR, Netdev List; +Cc: Andrew Morton, Linux Kernel

The following warning appears to be real:

drivers/atm/ambassador.c: In function ‘amb_open’:
drivers/atm/ambassador.c:1049: warning: ‘tx_rate_bits’ may be used 
uninitialized in this function

The variable is accessed before the make_rate() error code is checked, 
thus accessing an uninit'd value.

	Jeff



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: another ATM bug
  2006-10-01 13:34 another ATM bug Jeff Garzik
@ 2006-10-01 15:03 ` Mitchell Blank Jr
  0 siblings, 0 replies; 2+ messages in thread
From: Mitchell Blank Jr @ 2006-10-01 15:03 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: chas williams - CONTRACTOR, Netdev List

(cc:'s trimmed again)

Jeff Garzik wrote:
> drivers/atm/ambassador.c: In function ?amb_open?:
> drivers/atm/ambassador.c:1049: warning: ?tx_rate_bits? may be used 
> uninitialized in this function
> 
> The variable is accessed before the make_rate() error code is checked, 

Or rather, the make_rate() error code isn't checked AT ALL ("error"
appears to be a write-only variable)  That seems to be the real bug

-Mitch

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-10-01 14:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-01 13:34 another ATM bug Jeff Garzik
2006-10-01 15:03 ` Mitchell Blank Jr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).